ROX-26516: Introspection endpoint for runtime config #1879
Conversation
JoukoVirtanen
force-pushed
the
jv-ROX-26516-introspection-endpoint-for-runtime-config
branch
2 times, most recently
from
02326d9 to
691f393
Compare
|
I believe that the builder regeneration logic bases its decision on modifications that are part of the PR, which is incorrect here (the base PR modifies builder). Added the |
| CollectorConfigInspector::CollectorConfigInspector(const std::shared_ptr<CollectorConfig> config) : config_(config) { | ||
| } | ||
|
|
||
| Json::Value CollectorConfigInspector::configToJson() { |
There was a problem hiding this comment.
There are a few situations in this method that could be considered errors, like failing to convert the configuration to JSON, it'd be nice if we could change the HTTP status to 500 if one of these occur, maybe we can return a tuple with the result and the json? Or use a std::variant of sorts?
| Json::CharReaderBuilder readerBuilder; | ||
| std::string errs; | ||
| std::istringstream iss(jsonString); | ||
| if (!Json::parseFromStream(readerBuilder, iss, &root, &errs)) { | ||
| CLOG(ERROR) << "Failed to parse JSON string: " << errs; | ||
| return Json::Value(); | ||
| } |
There was a problem hiding this comment.
If the caller to this method is just going to grab the Json::Value object and turn it into a string, why are we grabbing a string and turning it into a Json::Value here? Why can't we just return the string?
Co-authored-by: Olivier Valentin <[email protected]> Co-authored-by: Mauro Ezequiel Moltrasio <[email protected]>
Co-authored-by: Mauro Ezequiel Moltrasio <[email protected]>
JoukoVirtanen
force-pushed
the
jv-ROX-26516-introspection-endpoint-for-runtime-config
branch
from
1aecc1f to
78fde17
Compare
JoukoVirtanen
deleted the
jv-ROX-26516-introspection-endpoint-for-runtime-config
branch
Description
Makes it possible to find the current state of the runtime configuration by querying a collector endpoint.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Deployed ACS on a GKE cluster. Changed the collector image to the one for this PR. Also added the following environment variable
Ran the following command
Queried the endpoint
and got this response
Set enableExternalIps to false
The result in this case was
Not using a ConfigMap
In this case the response was