Skip to content

Commit

Permalink
Review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Grzegorz Nosek <[email protected]>
  • Loading branch information
gnosek authored and poiana committed Sep 1, 2021
1 parent afb13cf commit 92d3cd4
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions proposals/20210818-driver-semver.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ prevent it.
1. Introduce an API version embedded in the userspace and kernel code
* The version number will be a single 64-bit number that can be decomposed
to the three semantic versioning components (major, minor, patch)
* As long as the API version is kept separate from any preexisting
consumer version numbers, the API version can start at 1.0.0.
The easiest way to accomplish this would be to rename the driver
(step 4).

2. Extend the review process to ensure the API version is incremented when needed.
Note that e.g. adding support for a new kernel should not result in an API
Expand All @@ -77,9 +81,11 @@ prevent it.
a warning (the driver is compatible but has known bugs, fixed in later
versions)

4. Remove consumer name and version from the libscap build process
* The probe should always be named `scap_probe` and use the API version to identify
4. Deemphasize consumer name and version from the libscap build process
* The driver should be named `scap` by default and use the API version to identify
itself
* An option may remain to override the driver name (and supply a version)
but it should not be used without good reason

## The non-plan

Expand Down

0 comments on commit 92d3cd4

Please sign in to comment.