Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade go dependencies #1424

Closed
wants to merge 3 commits into from
Closed

chore: upgrade go dependencies #1424

wants to merge 3 commits into from

Conversation

tommartensen
Copy link
Contributor

Cannot upgrade k8s.io Go dependencies because Argo v3.6.0 requires k8s.io at v0.30.x: argoproj/argo-workflows#13485 (comment)

@tommartensen tommartensen self-assigned this Nov 29, 2024
@tommartensen tommartensen requested a review from a team as a code owner November 29, 2024 09:28
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Nov 29, 2024

A single node development cluster (infra-pr-1424) was allocated in production infra for this PR.

CI will attempt to deploy quay.io/rhacs-eng/infra-server:0.10.53-3-g4d47865895 to it.

🔌 You can connect to this cluster with:

gcloud container clusters get-credentials infra-pr-1424 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:

nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🚲 You can then use the dev infra instance e.g.:

bin/infractl -k -e localhost:8443 whoami

⚠️ Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted. ⚠️

Further Development

☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.

🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:

make install-local

Logs

Logs for the development infra depending on your @redhat.com authuser:

Or:

kubectl -n infra logs -l app=infra-server --tail=1 -f

Copy link
Contributor

@davdhacs davdhacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tommartensen
Copy link
Contributor Author

actually tests fail and I don't know why, please don't merge!

@davdhacs davdhacs self-requested a review December 9, 2024 20:57
@tommartensen
Copy link
Contributor Author

Superseded by #1445

@tommartensen tommartensen deleted the tm/upgrade-deps branch December 19, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants