Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-27432: allow regex in authentication claimrules #1441

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

tommartensen
Copy link
Contributor

@tommartensen tommartensen commented Dec 17, 2024

This allows multiple (Rover) groups to be specified in the OIDC configuration.

@tommartensen tommartensen self-assigned this Dec 17, 2024
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Dec 17, 2024

A single node development cluster (infra-pr-1441) was allocated in production infra for this PR.

CI will attempt to deploy quay.io/rhacs-eng/infra-server:0.10.59-4-g2eaa54df2d to it.

🔌 You can connect to this cluster with:

gcloud container clusters get-credentials infra-pr-1441 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:

nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🚲 You can then use the dev infra instance e.g.:

bin/infractl -k -e localhost:8443 whoami

⚠️ Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted. ⚠️

Further Development

☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.

🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:

make install-local

Logs

Logs for the development infra depending on your @redhat.com authuser:

Or:

kubectl -n infra logs -l app=infra-server --tail=1 -f

@tommartensen tommartensen changed the title allow regex in claimrules ROX-27432: allow regex in claimrules Dec 17, 2024
@tommartensen tommartensen changed the title ROX-27432: allow regex in claimrules ROX-27432: allow regex in authentication claimrules Dec 17, 2024
@tommartensen tommartensen marked this pull request as ready for review December 17, 2024 11:14
@tommartensen tommartensen requested a review from a team as a code owner December 17, 2024 11:14
"field": "val3",
},
rules: ClaimRules{{
Value: "(val1|val2)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be useful to test that val3xyz does not trigger as a match, and prevent a regression that would allow subset matches?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added additional substring tests in 2eaa54d.

I am preventing substring matching by wrapping the test string with ^$: https://github.com/stackrox/infra/pull/1441/files#diff-4686f933d92fd202f84313c97ceb4ee8b35f5eb949a71b7ab8a6687a452947daR74

@tommartensen tommartensen enabled auto-merge (squash) December 18, 2024 08:45
@tommartensen tommartensen merged commit 098706a into master Dec 18, 2024
10 checks passed
@tommartensen tommartensen deleted the tm/allow-regex-in-claimrules branch December 18, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants