-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-27432: allow regex in authentication claimrules #1441
Conversation
A single node development cluster (infra-pr-1441) was allocated in production infra for this PR. CI will attempt to deploy 🔌 You can connect to this cluster with:
🛠️ And pull infractl from the deployed dev infra-server with:
🚲 You can then use the dev infra instance e.g.:
Further Development☕ If you make changes, you can commit and push and CI will take care of updating the development cluster. 🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:
LogsLogs for the development infra depending on your @redhat.com authuser: Or:
|
"field": "val3", | ||
}, | ||
rules: ClaimRules{{ | ||
Value: "(val1|val2)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be useful to test that val3xyz
does not trigger as a match, and prevent a regression that would allow subset matches?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added additional substring tests in 2eaa54d.
I am preventing substring matching by wrapping the test string with ^$
: https://github.com/stackrox/infra/pull/1441/files#diff-4686f933d92fd202f84313c97ceb4ee8b35f5eb949a71b7ab8a6687a452947daR74
This allows multiple (Rover) groups to be specified in the OIDC configuration.