-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-19609: add cluster name validation to infractl #980
Conversation
A single node development cluster (infra-pr-980) was allocated in production infra for this PR. CI will attempt to deploy us.gcr.io/stackrox-infra/infra-server:0.7.11-8-gcf14f7a5d0 to it. 🔌 You can connect to this cluster with:
🛠️ And pull infractl from the deployed dev infra-server with:
🚲 You can then use the dev infra instance e.g.:
Further Development☕ If you make changes, you can commit and push and CI will take care of updating the development cluster. 🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:
LogsLogs for the development infra depending on your @stackrox.com authuser: Or:
|
@@ -123,6 +123,24 @@ setup() { | |||
assert_output --partial "parameter \"main-image\" was not provided" | |||
} | |||
|
|||
@test "provided name failed validation because too short" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gets the job done. Ideally the cluster flavor should tell infra how to validate the name but that plumbing does not exist.
Different requirements or allowed characters for different flavors might complicate the naming for users. I am in favor of keeping the current approach using the common denominator of allowed cluster names. |
This was a user request: https://issues.redhat.com/browse/ROX-19609.