-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-19655: build infra with multi-stage image #981
Conversation
A single node development cluster (infra-pr-981) was allocated in production infra for this PR. CI will attempt to deploy us.gcr.io/stackrox-infra/infra-server:0.7.11-11-gca7882e581 to it. 🔌 You can connect to this cluster with:
🛠️ And pull infractl from the deployed dev infra-server with:
🚲 You can then use the dev infra instance e.g.:
Further Development☕ If you make changes, you can commit and push and CI will take care of updating the development cluster. 🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:
LogsLogs for the development infra depending on your @stackrox.com authuser: Or:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One little nit, just in case
|
||
FROM alpine:3.18.3 as app | ||
|
||
COPY --from=golang-builder /go/src/github.com/stackrox/infra/bin/infra-server-linux-amd64 /infra-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably silly to bring up, but is there a possibility that rhtap doesn't use amd64 (I know cloud providers have been making arm64 more relevant these days)? If that's a concern, we can do a regular go build
so it creates a binary for the arch that's building it (this assumes they build the container image with the same arch). Not gonna block on this tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not silly. RHTAP only supports amd64
builds, with multi-arch planned for beginning of next year.
I would leave it as is, as we'll keep using the GHA build for a while :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.