ROX-20769: Add PG flavor to the stackrox-test image #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davdhacs
reviewed
Feb 12, 2025
stackrox-test image is used to run go-postgres tests and has PostgreSQL installed for that purposes. Now we come to the point that ACS has to be tested against multiple versions. To support that, add all needed binaries into the test image and let the consumers choose which version to use via modifying the PATH.
erthalion
force-pushed
the
feature/add-pg-flavor
branch
from
43fb05c to
3af87b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stackrox-test image is used to run go-postgres tests and has PostgreSQL installed for that purposes. Now we come to the point that ACS has to be tested against multiple versions. To support that, produce images with a specified PG version in the form
"stackrox-test-$(TEST_TAG)-pg$(PG_VERSION)". The main image will stay there without any changes, and only a consumer CI pipeline that would like to exercise different versions will pick it up.