Skip to content

Commit

Permalink
Update to go1.19.4 (#1083)
Browse files Browse the repository at this point in the history
  • Loading branch information
RTann authored Feb 8, 2023
1 parent d6ff6c8 commit 91f5a3c
Show file tree
Hide file tree
Showing 7 changed files with 21 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .openshift-ci/Dockerfile.build_root
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@
# - `make update` and commit the results
# - run `/test pj-rehearse-max` on the openshift/release PR to validate the change

FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.3.51
FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.3.56
2 changes: 1 addition & 1 deletion .openshift-ci/build/Dockerfile.build-bundle
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.3.51
FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.3.56

COPY . /go/src/github.com/stackrox/scanner
WORKDIR /go/src/github.com/stackrox/scanner
Expand Down
2 changes: 1 addition & 1 deletion .openshift-ci/build/Dockerfile.build-db-bundle
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.3.51
FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.3.56

COPY . /go/src/github.com/stackrox/scanner
WORKDIR /go/src/github.com/stackrox/scanner
Expand Down
2 changes: 1 addition & 1 deletion .openshift-ci/build/Dockerfile.generate-db-dump
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.3.51
FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.3.56

COPY . /go/src/github.com/stackrox/scanner
WORKDIR /go/src/github.com/stackrox/scanner
Expand Down
2 changes: 1 addition & 1 deletion .openshift-ci/build/Dockerfile.generate-genesis-dump
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.3.51
FROM quay.io/stackrox-io/apollo-ci:scanner-test-0.3.56

COPY . /go/src/github.com/stackrox/scanner
WORKDIR /go/src/github.com/stackrox/scanner
Expand Down
2 changes: 1 addition & 1 deletion BUILD_IMAGE_VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
scanner-build-0.3.51
scanner-build-0.3.56
15 changes: 15 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,21 @@ $ make image

For any other time, just run `make image`.

## Updating CI base image

The Scanner repository relies on the images built in https://github.com/stackrox/rox-ci-image
for CI. Sometimes, it is necessary to update the image used
(for example, to build Scanner with an updated Go version).

To do this, only the following is necessary:

* Update [BUILD_IMAGE_VERSION](BUILD_IMAGE_VERSION)
* Update [.openshift-ci/Dockerfile.build_root](.openshift-ci/Dockerfile.build_root)

There are other references to apollo-ci images within .openshift-ci/build.
It is not necessary to update those for CI, as OpenShift CI will NOT use the
FROM inside the respective Dockerfile.

## Testing

There are various unit tests and bench tests scattered around the codebase.
Expand Down

0 comments on commit 91f5a3c

Please sign in to comment.