ROX-19942: support usr/lib/redhat-release and RHEL Atomic Host release #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTann
requested review from
jvdm,
connorgorman,
BradLugo,
daynewlee,
dcaravel and
a team
|
Images are ready for the commit at 45dff4d. To use the images, use the tag |
jvdm
approved these changes
Oct 4, 2023
| @@ -32,11 +32,12 @@ var ( | |||
| blocklistFilenames = []string{ | |||
| "etc/alpine-release", | |||
| "etc/centos-release", | |||
| "usr/lib/centos-release", | |||
| "etc/fedora-release", | |||
There was a problem hiding this comment.
I am wondering about fedora, too, since it's upstream.
There was a problem hiding this comment.
We don't support Fedora in Scanner v2, so I considered removing this, but I decided against it because I didn't want to touch anything unrelated to the goal of this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible an official Red Hat container image has
etc/redhat-releaseas a symlink tousr/lib/redhat-releaseinstead of being a regular file. This PR addsusr/lib/redhat-releaseas a file to track.It also updates the
etc/os-releasesupport for RHEL/CentOS in case there may be some other case we miss. The update ensures only the major version of the release is returned when reading a RHEL or CentOS namespace frometc/os-release.