Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate v4 versioned offline vuln #1403

Merged
merged 4 commits into from
Feb 9, 2024
Merged

Conversation

daynewlee
Copy link
Contributor

@daynewlee daynewlee commented Feb 9, 2024

Generate scanner-vulns-{version}.zip for scanner v4 offline mode

Due to time constraints and my limited understanding of decoupling ci.yaml and diff-dump (just for testing), I directly modified the diff-dump.sh script.

@daynewlee daynewlee changed the base branch from master to yli3/v4Dump February 9, 2024 03:30
@daynewlee daynewlee marked this pull request as draft February 9, 2024 03:30
@daynewlee daynewlee added generate-dumps-on-pr Generates the image based on dumps from the PR and removed generate-dumps-on-pr Generates the image based on dumps from the PR labels Feb 9, 2024
@daynewlee daynewlee marked this pull request as ready for review February 9, 2024 12:26
@daynewlee daynewlee added the generate-dumps-on-pr Generates the image based on dumps from the PR label Feb 9, 2024
@daynewlee daynewlee removed the generate-dumps-on-pr Generates the image based on dumps from the PR label Feb 9, 2024
Copy link
Contributor

@dcaravel dcaravel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcaravel
Copy link
Contributor

dcaravel commented Feb 9, 2024

There are multiple jobs now referring to the scanner-v4-test bucket, not all with TODO's next to them - need to make sure to clean all instances up before release.

@daynewlee daynewlee merged commit b071780 into yli3/v4Dump Feb 9, 2024
14 checks passed
@daynewlee daynewlee deleted the yli3/v4VersionDump branch February 9, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants