Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ROX-23707): scanner-db-slim must have an initdb entrypoint directory #1536

Conversation

tommartensen
Copy link
Contributor

@tommartensen tommartensen commented Jun 4, 2024

Bug: scanner-db-slim did not start in secured cluster.
Root cause: initdb directory missing, present in scanner-db when COPYing.

Tested in https://acs-cpesspbhcl5s73a1atfg.acs-integration.rhcloud.com/main/clusters/992d6d75-8796-47f5-b731-a2beb00465dd .

Bumped the scanner version in stackrox/stackrox@3ecfada and deployed a newer operator version.

Copy link

openshift-ci bot commented Jun 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tommartensen tommartensen marked this pull request as ready for review June 4, 2024 15:00
@tommartensen tommartensen requested a review from a team June 4, 2024 15:02
@tommartensen tommartensen enabled auto-merge (squash) June 4, 2024 15:02
Copy link
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! My comment is optional.

@@ -33,7 +33,8 @@ RUN dnf upgrade -y --nobest && \
dnf clean all && \
rpm --verbose -e --nodeps $(rpm -qa curl '*rpm*' '*dnf*' '*libsolv*' '*hawkey*' 'yum*') && \
rm -rf /var/cache/dnf /var/cache/yum && \
chmod +x /usr/local/bin/docker-entrypoint.sh
chmod +x /usr/local/bin/docker-entrypoint.sh && \
mkdir /docker-entrypoint-initdb.d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mkdir /docker-entrypoint-initdb.d
mkdir -p /docker-entrypoint-initdb.d

Up to you since the dir should not exist anyway.

@tommartensen tommartensen merged commit 74cc995 into master Jun 4, 2024
34 of 38 checks passed
@tommartensen tommartensen deleted the tm/ROX-23707-konflux-fix-scanner-slim-db-init-entrypoint branch June 4, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants