Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-20855: Reduce container user permissions over docker-entrypoint.sh #1542

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

msugakov
Copy link
Contributor

@msugakov msugakov commented Jun 7, 2024

There's no need to own executable by postgres user, hence removed chown.

There's no need to add executable flag because COPY statement preserves it and the original file has it, hence removed chmod.

There's no need to own executable by `postgres` user,
hence removed `chown`.

There's no need to add executable flag because `COPY` statement
preserves it and the original file has it, hence removed `chmod`.
@msugakov msugakov requested review from kylape, RTann, tommartensen and a team June 7, 2024 14:48
Copy link
Collaborator

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and normal CI tests pass, but I'm not familiar with the konflux failures

@msugakov
Copy link
Contributor Author

msugakov commented Jun 7, 2024

Konflux enterprise-contract failures are noise at the moment, it's ok to ignore them.

@msugakov msugakov merged commit c0dc1f0 into master Jun 7, 2024
34 of 38 checks passed
@msugakov msugakov deleted the misha/ROX-20855-less-ownership-in-konflux branch June 7, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants