ROX-25321: convert konflux builds to OCI artifacts #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
Stringy
force-pushed
the
giles/konflux/ROX-25321-migrate-scanner-to-oci-artifacts
branch
from
bc911af to
695e7c1
Compare
| runAfter: | ||
| - build-container | ||
| - name: SOURCE_ARTIFACT | ||
| value: $(tasks.prefetch-dependencies.results.SOURCE_ARTIFACT) |
There was a problem hiding this comment.
Could/should this be tasks.fetch-scanner-data.results.SOURCE_ARTIFACT as the last task that edited the source?
(it won't matter for what this task attempts to achieve, nor for the order of tasks, just for the next person to copy&paste the params from this task to a latter task)
There was a problem hiding this comment.
I've also switched sast-snyk-check to the fetch-scanner-data source artifact for consistency
tommartensen
approved these changes
Jul 22, 2024
Stringy
deleted the
giles/konflux/ROX-25321-migrate-scanner-to-oci-artifacts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the pipeline to use OCI artifacts, in a similar way to the other ACS components.