Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update oci-ta tasks, add Renovate config #1575

Conversation

red-hat-konflux[bot]
Copy link
Contributor

@red-hat-konflux red-hat-konflux bot commented Jul 22, 2024

@msugakov: I took over this PR adding more maintenance things on top of Renovate's change.
It's best to review this PR per commit.

Relates to ROX-22359

@red-hat-konflux red-hat-konflux bot requested a review from a team as a code owner July 22, 2024 16:08
Copy link

openshift-ci bot commented Jul 22, 2024

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@msugakov
Copy link
Contributor

/renovate rebase

@red-hat-konflux red-hat-konflux bot force-pushed the renovate/quay.io-redhat-appstudio-build-trusted-artifacts-latest branch from eaba2df to 9b66f84 Compare July 24, 2024 08:12
@msugakov
Copy link
Contributor

msugakov commented Jul 24, 2024

This is going to be fun: there's a behavior change in the task so that it does not seem to allow passing through the chain.
DBs failed but scanners did not. Probably because DBs don't do any actual dependency prefetch. I think we should just put blobs fetch before dependencies prefetch to solve the issue.

@msugakov msugakov force-pushed the renovate/quay.io-redhat-appstudio-build-trusted-artifacts-latest branch from 9b66f84 to f7deab1 Compare August 5, 2024 09:16
@msugakov msugakov changed the title chore(deps): update quay.io/redhat-appstudio/build-trusted-artifacts:latest docker digest to ad38a34 chore(deps): update build-trusted-artifacts, other maintenance Aug 5, 2024
@msugakov msugakov self-assigned this Aug 5, 2024
@msugakov
Copy link
Contributor

msugakov commented Aug 5, 2024

/ok-to-test

@msugakov msugakov changed the title chore(deps): update build-trusted-artifacts, other maintenance chore(deps): update build-trusted-artifacts, add Renovate config Aug 5, 2024
red-hat-konflux bot and others added 4 commits August 5, 2024 11:21
…latest docker digest to ad38a34

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Just used IDE shortcuts without any manual edits.
This should fix failures like in
https://console.redhat.com/application-pipeline/workspaces/rh-acs/applications/acs/pipelineruns/scanner-db-build-vtkz6

In `fetch-scanner-data`:

```
Invalid task result reference: Could not find result with name SOURCE_ARTIFACT for task fetch-scanner-data
```

```
[create-trusted-artifact] WARN: found skip file in /var/workdir/source
[create-trusted-artifact]
```
Took a copy from stackrox/stackrox, without `printConfig`.
@msugakov msugakov force-pushed the renovate/quay.io-redhat-appstudio-build-trusted-artifacts-latest branch from f7deab1 to d67f339 Compare August 5, 2024 09:21
because they aren't used anywhere
@msugakov msugakov changed the title chore(deps): update build-trusted-artifacts, add Renovate config chore: update build-trusted-artifacts, add Renovate config Aug 5, 2024
File names weren't consistent but we can actually now drop `oci-ta`
stuff because non-oci tasks are gone.
@msugakov msugakov force-pushed the renovate/quay.io-redhat-appstudio-build-trusted-artifacts-latest branch from 2ea005c to 91cfe46 Compare August 5, 2024 09:30
@msugakov msugakov changed the title chore: update build-trusted-artifacts, add Renovate config chore: Update determine-image-tag, add Renovate config Aug 5, 2024
@msugakov msugakov changed the title chore: Update determine-image-tag, add Renovate config chore: Update oci-ta tasks, add Renovate config Aug 5, 2024
@msugakov
Copy link
Contributor

msugakov commented Aug 5, 2024

/retest

@msugakov msugakov requested a review from tommartensen August 5, 2024 18:05
Copy link
Contributor

@tommartensen tommartensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't understand how switching the order of tasks will do anything to resolve the issue you mention (or what caused it in the first place)

@msugakov
Copy link
Contributor

msugakov commented Aug 6, 2024

It seems to me that prefetch tasks puts some skip marker file so that the next attempt to save oci artifact bails out respecting that file.

@msugakov
Copy link
Contributor

msugakov commented Aug 6, 2024

@tommartensen
Copy link
Contributor

It seems to me that prefetch tasks puts some skip marker file so that the next attempt to save oci artifact bails out respecting that file.

👍
Could you check that the pipeline run timeout is still accurate?

Copy link

openshift-ci bot commented Aug 6, 2024

@red-hat-konflux[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/scale-tests aac7b78 link false /test scale-tests
ci/prow/slim-e2e-tests aac7b78 link false /test slim-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@msugakov
Copy link
Contributor

msugakov commented Aug 6, 2024

/retest scanner-db-build

This comment was marked as off-topic.

@msugakov
Copy link
Contributor

msugakov commented Aug 6, 2024

scanner-db-build even if it timeouts got successfully to the last two tasks. It was just slow due to multiarch and pipelines slowness. I don't want to bump *-db-* timeouts just yet. Will merge.

@msugakov msugakov merged commit 36be38a into master Aug 6, 2024
31 of 37 checks passed
@msugakov msugakov deleted the renovate/quay.io-redhat-appstudio-build-trusted-artifacts-latest branch August 6, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants