-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update oci-ta tasks, add Renovate config #1575
chore: Update oci-ta tasks, add Renovate config #1575
Conversation
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
/renovate rebase |
eaba2df
to
9b66f84
Compare
This is going to be fun: there's a behavior change in the task so that it does not seem to allow passing through the chain. |
9b66f84
to
f7deab1
Compare
/ok-to-test |
…latest docker digest to ad38a34 Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Just used IDE shortcuts without any manual edits.
This should fix failures like in https://console.redhat.com/application-pipeline/workspaces/rh-acs/applications/acs/pipelineruns/scanner-db-build-vtkz6 In `fetch-scanner-data`: ``` Invalid task result reference: Could not find result with name SOURCE_ARTIFACT for task fetch-scanner-data ``` ``` [create-trusted-artifact] WARN: found skip file in /var/workdir/source [create-trusted-artifact] ```
Took a copy from stackrox/stackrox, without `printConfig`.
f7deab1
to
d67f339
Compare
because they aren't used anywhere
File names weren't consistent but we can actually now drop `oci-ta` stuff because non-oci tasks are gone.
2ea005c
to
91cfe46
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I don't understand how switching the order of tasks will do anything to resolve the issue you mention (or what caused it in the first place)
It seems to me that prefetch tasks puts some skip marker file so that the next attempt to save oci artifact bails out respecting that file. |
The pipeline run where this happened is https://console.redhat.com/application-pipeline/workspaces/rh-acs/applications/acs/pipelineruns/scanner-db-build-vtkz6 |
👍 |
@red-hat-konflux[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest scanner-db-build |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@msugakov: I took over this PR adding more maintenance things on top of Renovate's change.
It's best to review this PR per commit.
Relates to ROX-22359