Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add ^release- branches for on-push Konflux builds #1586

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

msugakov
Copy link
Contributor

@msugakov msugakov commented Aug 5, 2024

This should enable Konflux builds from release branches for the case when SCANNER_VERSION points to a tag/commit that was on a release branch, not on master.

See also: https://redhat-internal.slack.com/archives/C079XCJEZK6/p1721729454430659?thread_ts=1721678052.993799&cid=C079XCJEZK6

Prerequisite for https://issues.redhat.com/browse/ROX-24468.

Available CEL functions are here https://github.com/google/cel-spec/blob/master/doc/langdef.md#list-of-standard-definitions.

@msugakov msugakov requested review from RTann, tommartensen and a team August 5, 2024 18:51
@msugakov msugakov requested a review from a team as a code owner August 5, 2024 18:51
@msugakov msugakov marked this pull request as draft August 5, 2024 19:00
Copy link
Collaborator

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I don't know why those "acs-enterprise-contract" jobs are failing. When I click on them the UI either gives me a 502 or says the logs don't exist

Copy link
Collaborator

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this will capture all pushes to the release branches, right? Do we want that or to just capture all tag events (if that's posible)?

@msugakov
Copy link
Contributor Author

msugakov commented Aug 6, 2024

Thanks for the approval Ross

Regarding acs-enterprise-contract: it's unfortunately broken for all our Konflux builds. We look into this.
It's not stable yet and failures are more common than successes. Additionally, there are sporadic problems with Konflux Console.
It's fine :-) ...for now.

Regarding tags: it's a good question, and we can match on tags (example here) but at this point I fully don't know what we need yet.
I think, running Konflux on pushes to release branches which are not just tags has a benefit of giving a CI signal whether the release branch builds well.

I suggest we start like this and later see how to adjust. We can configure to build on tags in addition or instead of building on release branches, when needed.

@msugakov msugakov marked this pull request as ready for review August 6, 2024 08:06
@msugakov msugakov merged commit d2d4069 into master Aug 6, 2024
32 of 38 checks passed
@msugakov msugakov deleted the misha/build-scanner-release-in-konflux branch August 6, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants