Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add Konflux pipeline activation through a label #1593

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

msugakov
Copy link
Contributor

@msugakov msugakov commented Aug 8, 2024

Copy link

openshift-ci bot commented Aug 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

GoLand highlights it as not modifiable by user and so no reason to
have it in our manifests.
@msugakov msugakov added the konflux-build Run Konflux in PR. Push commit to trigger it. label Aug 8, 2024
@msugakov
Copy link
Contributor Author

msugakov commented Aug 8, 2024

Figured (#1594) that body.pull_request.labels look the following way:

    "labels": [
      {
        "color": "ededed",
        "default": false,
        "id": 4164972636,
        "name": "do-not-merge/work-in-progress",
        "node_id": "LA_kwDODLkO9s74QHBc",
        "url": "https://api.github.com/repos/stackrox/scanner/labels/do-not-merge/work-in-progress"
      },
      {
        "color": "D55C85",
        "default": false,
        "description": "Tells (Konflux) Renovate bot to calm down and not send more updates to this PR.",
        "id": 6987805440,
        "name": "stop-updating",
        "node_id": "LA_kwDODLkO9s8AAAABoIFzAA",
        "url": "https://api.github.com/repos/stackrox/scanner/labels/stop-updating"
      },
      {
        "color": "B0FE49",
        "default": false,
        "description": "Enable Konflux builds in this PR",
        "id": 7304553284,
        "name": "konflux-build",
        "node_id": "LA_kwDODLkO9s8AAAABs2KjRA",
        "url": "https://api.github.com/repos/stackrox/scanner/labels/konflux-build"
      }
    ],

@msugakov msugakov requested a review from tommartensen August 8, 2024 09:04
@msugakov msugakov marked this pull request as ready for review August 8, 2024 09:04
@msugakov msugakov requested a review from a team as a code owner August 8, 2024 09:04
@tommartensen
Copy link
Contributor

Is the pipeline also triggered when you add or remove the label? From what I can see in the history of this PR, you added the label, then pushed 53b0dcc, for which Konflux started to run.

@msugakov
Copy link
Contributor Author

msugakov commented Aug 8, 2024

The pipeline does not start after I just add the label. Something needs to be committed to the PR branch. This works similar to our existing labels in stackrox project.

@tommartensen
Copy link
Contributor

The pipeline does not start after I just add the label. Something needs to be committed to the PR branch. This works similar to our existing labels in stackrox project.

GHA and OSCI can be triggered just by adding the label, e.g. backport release-4.5 labels work like that.
might be a question for #konflux-users.

@msugakov
Copy link
Contributor Author

msugakov commented Aug 8, 2024

msugakov added a commit to stackrox/stackrox that referenced this pull request Aug 9, 2024
from stackrox/scanner#1593

* simplifies branch name matching
* adds builds for release branches (we'll figure later if we need it)
* enables Konflux CI on PR label
@msugakov
Copy link
Contributor Author

/test scanner-db-slim-build

This comment was marked as outdated.

@msugakov msugakov merged commit 48af785 into master Aug 12, 2024
34 of 38 checks passed
@msugakov msugakov deleted the misha/label-triggering branch August 12, 2024 07:56
msugakov added a commit to stackrox/collector that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
konflux-build Run Konflux in PR. Push commit to trigger it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants