-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update docker dep to fix CVE-2024-41110 #1607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but something to think about: I'm pretty confident we are not affected by this. I think this just affects the docker engine runtime, which we aren't running/using.
Also, you may have to rebase? I actually just cherry-picked d4b374d into this branch, and it modified the go.mod/go.sum |
Images are ready for the commit at 20cf1cb. To use the images, use the tag |
Agreed, I'm sure some scanners would report it regardless, this would at least eliminate some future false positives / headaches.
ACK - right now seems OK but will rebase |
8337254
to
20cf1cb
Compare
@dcaravel: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Test failure unrelated to change - tests were fixed in this PR #1567 (has not been backported to this branch) |
Updates
github.com/docker/docker
to address CVE-2024-41110 targeting Scanner2.33.6
and Stackrox4.4.5
Expecting scanner version
2.33.6
to contain this change and be used in this backport: stackrox/stackrox#12422