Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yearly cert bump #1748

Merged
merged 1 commit into from
Dec 18, 2024
Merged

yearly cert bump #1748

merged 1 commit into from
Dec 18, 2024

Conversation

RTann
Copy link
Collaborator

@RTann RTann commented Dec 18, 2024

Followed the steps in https://github.com/stackrox/scanner/blob/master/scripts/cert/README.md

Also added a yearly reminder on Slack. Hoping we don't need to do this anymore, though... :)

Copy link

openshift-ci bot commented Dec 18, 2024

@RTann: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 8c01dcb link false /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@BradLugo
Copy link
Contributor

@RTann can you confirm the osci failure isn't related to this change? Doesn't seem so to me, but wanted to double-check before giving an approval

Copy link
Contributor

@dcaravel dcaravel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, see the certs are indeed expired:

cat << EOF | base64 -d | openssl x509 -text -noout
LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUNURENDQWZLZ0F3SUJBZ0lVTVVIdDM4MWpITTAyOUtpV0xtcFEzTUg4TFVzd0NnWUlLb1pJemowRUF3SXcKWmpFTE1Ba0dBMVVFQmhNQ1ZWTXhGekFWQmdOVkJBZ1REazV2Y25Sb0lFTmhjbTlzYVc1aE1SQXdEZ1lEVlFRSApFd2RTWVd4bGFXZG9NUll3RkFZRFZRUUtFdzFTWldRZ1NHRjBMQ0JKYm1NdU1SUXdFZ1lEVlFRTEV3dEZibWRwCmJtVmxjbWx1WnpBZUZ3MHlNekV5TVRZd05UVTRNREJhRncweU5ERXlNVFV3TlRVNE1EQmFNR1l4Q3pBSkJnTlYKQkFZVEFsVlRNUmN3RlFZRFZRUUlFdzVPYjNKMGFDQkRZWEp2YkdsdVlURVFNQTRHQTFVRUJ4TUhVbUZzWldsbgphREVXTUJRR0ExVUVDaE1OVW1Wa0lFaGhkQ3dnU1c1akxqRVVNQklHQTFVRUN4TUxSVzVuYVc1bFpYSnBibWN3CldUQVRCZ2NxaGtqT1BRSUJCZ2dxaGtqT1BRTUJCd05DQUFRR2RPdlczQzRDajRRbkY3K295dFNrSVJHbGx2RHMKeVRUNVZtV2F1VjhrVXhpdXJzcTZ2cmp4b01CQnRCNEJiTGVzUHprSjFTbTBtQmhndHg1WThqTWtvMzR3ZkRBTwpCZ05WSFE4QkFmOEVCQU1DQmFBd0hRWURWUjBsQkJZd0ZBWUlLd1lCQlFVSEF3RUdDQ3NHQVFVRkJ3TUNNQXdHCkExVWRFd0VCL3dRQ01BQXdIUVlEVlIwT0JCWUVGSE9ZNkw2MVNuNzNwZXI2czRKUlBHYXlZZlliTUI0R0ExVWQKRVFRWE1CV0NFM05qWVc1dVpYSXRaR0l1YzNSaFkydHliM2d3Q2dZSUtvWkl6ajBFQXdJRFNBQXdSUUloQU9CYgpHdGpNQ3ZEcVF6eFNrTXJHSzZjcUllTjk2eUR6dXRTV2hNbkdXMnBFQWlBeDhVMFV6Z1NkOU8xYjhrMTlJLzRmCnNlYzEyS2pwTG4xMXp6Y0lkRzN6YXc9PQotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg==
EOF
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            31:41:ed:df:cd:63:1c:cd:36:f4:a8:96:2e:6a:50:dc:c1:fc:2d:4b
        Signature Algorithm: ecdsa-with-SHA256
        Issuer: C=US, ST=North Carolina, L=Raleigh, O=Red Hat, Inc., OU=Engineering
        Validity
            Not Before: Dec 16 05:58:00 2023 GMT
            Not After : Dec 15 05:58:00 2024 GMT

Looks like CI for this PR failed due to a timeout, which is addressed in #1737 FYI

Please address @BradLugo's comment as well.

@RTann
Copy link
Collaborator Author

RTann commented Dec 18, 2024

Yeah @BradLugo from what I can tell the failures are a combo of things addressed in Dave's PR #1737. Those nils are due to the timeout. Going to merge

@RTann RTann merged commit fb6e36e into master Dec 18, 2024
29 of 30 checks passed
@RTann RTann deleted the ross-12-2024-certs branch December 18, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants