[DRAFT] ROX-8711 Test suite for deployment bundles #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This work is part of a proof-of-concept for https://issues.redhat.com/browse/ROX-8711.
The basic idea here is that we would like to execute the Helm chart's test suite also in the case where we pre-render the chart files in "deployment bundle mode".
However, the difficulty is that in general the tests require some modification depending on whether executed in the "Helm chart mode" or in the "deployment bundle mode".
This PR depends on this (draft) PR for helmtest: stackrox/helmtest#7.
The helmtest PR extends the helmtest framework such that tests can be run selectively, depending on a "flavour" value, which is passed in by the user of helmtest and which can be accessed by the leave tests defined in the test suite.
This PR extends the test suite for the securedcluster Helm chart such that in addition to what it currently does it instantiates the chart in the "bundle" mode and runs helmtest with the "bundle" flavour being specified.
(Almost) all currently defined tests are moved into a subdirectory "chart", because they are currently specific for the chart use-case.
A new directory "bundle" is created, which contains (almost) identical basic definitions as the "chart" specific test suite.
One test,
cluster-name.yaml
, has been moved from thechart
directory into a newshared
directory. The test in that file has been protected with a condition such that it is only executed in the chart test. A slightly modified copy of this test has been appended in the same file which is only executed in the bundle test suite. This file has been symlinked to thechart
and thebundle
directory.Checklist
Evaluated and added CHANGELOG entry if requiredDetermined and documented upgrade stepsTesting Performed
This is about extending the test coverage.