-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proptests for the "skip" functions in tuple deserialization #520
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
- Coverage 86.14% 86.11% -0.03%
==========================================
Files 44 44
Lines 20942 20968 +26
Branches 20942 20968 +26
==========================================
+ Hits 18040 18057 +17
- Misses 1361 1368 +7
- Partials 1541 1543 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on that! It seems to be covering all cased that should be skipped during tuples deserialization.
Added some changes request that might improve the code a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…f match on Result
Closes #487
This PR implements 3 property tests for the deserialization of tuples with extra fields. This indirectly tests the "skip" functions from standard.wat.