Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proptests for the "skip" functions in tuple deserialization #520

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

Acaccia
Copy link
Collaborator

@Acaccia Acaccia commented Sep 25, 2024

Closes #487

This PR implements 3 property tests for the deserialization of tuples with extra fields. This indirectly tests the "skip" functions from standard.wat.

@Acaccia Acaccia requested review from csgui and krl September 25, 2024 15:31
@Acaccia Acaccia self-assigned this Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.11%. Comparing base (1a1ab12) to head (a5e9e5a).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
- Coverage   86.14%   86.11%   -0.03%     
==========================================
  Files          44       44              
  Lines       20942    20968      +26     
  Branches    20942    20968      +26     
==========================================
+ Hits        18040    18057      +17     
- Misses       1361     1368       +7     
- Partials     1541     1543       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@csgui csgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on that! It seems to be covering all cased that should be skipped during tuples deserialization.

Added some changes request that might improve the code a bit.

clar2wasm/tests/wasm-generation/consensus_buff.rs Outdated Show resolved Hide resolved
clar2wasm/tests/wasm-generation/consensus_buff.rs Outdated Show resolved Hide resolved
@Acaccia Acaccia requested a review from csgui September 26, 2024 11:03
csgui
csgui previously approved these changes Sep 26, 2024
Copy link
Collaborator

@csgui csgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Acaccia Acaccia added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 3d8adaa Sep 26, 2024
13 of 15 checks passed
@Acaccia Acaccia deleted the test/skip-functions branch September 26, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property tests for the stdlib skip functions
2 participants