Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wasmtime::Engine provided by GlobalContext #558

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

ureeves
Copy link
Collaborator

@ureeves ureeves commented Nov 14, 2024

See-also: #468

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.40%. Comparing base (f36423b) to head (a37aef1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   86.40%   86.40%           
=======================================
  Files          45       45           
  Lines       22694    22694           
  Branches    22694    22694           
=======================================
  Hits        19609    19609           
  Misses       1442     1442           
  Partials     1643     1643           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@krl krl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ureeves ureeves added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 112f4ca Nov 14, 2024
15 checks passed
@ureeves ureeves deleted the single-wasmtime-engine branch November 14, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants