Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding undocumented setting #1645

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Adding undocumented setting #1645

merged 1 commit into from
Sep 27, 2024

Conversation

wileyj
Copy link
Contributor

@wileyj wileyj commented Sep 27, 2024

Description

Learned of a new signer option block_proposal_timeout_ms - useful in case a miner is slow to broadcast blocks, this allows the singer to wait longer before rejecting a block proposal from a valid miner.

this setting is more relevant to distributed testnets/mocknets than mainnet.

@wileyj wileyj requested a review from a team as a code owner September 27, 2024 14:17
Copy link
Collaborator

@BowTiedDevOps BowTiedDevOps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wileyj wileyj merged commit 3fa7523 into master Sep 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants