Fix 500 error for empty file uploads with Azure driver #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Likely fix for flaky s3 bucket cleanup test failures
* Upgrade to Node.js active LTS (v12.x) * npm audit security updates
This was
linked to
issues
Feb 10, 2020
Codecov Report
@@ Coverage Diff @@
## develop #296 +/- ##
===========================================
+ Coverage 79.63% 87.56% +7.93%
===========================================
Files 23 14 -9
Lines 1748 1472 -276
Branches 315 279 -36
===========================================
- Hits 1392 1289 -103
+ Misses 272 109 -163
+ Partials 84 74 -10 Continue to review full report at Codecov.
|
timstackblock
requested review from
timstackblock
and removed request for
timstackblock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of PR
Fix #292
Fix #293
Fix regression where Azure driver was throwing a 5xx server error when a
content-length: 0header file POST was made.Added integration tests for these cases -- found and fixed a bug with S3 driver returning undefined content-length in the same scenario.
Misc package upgrades.
Submission Checklist
Based on correct branch: feature submissions should be on
develop, hotfixes should be onmasterThe code passes our eslint definitions, unit tests, and
contains correct TypeFlow annotations.
Submission contains tests that cover any and all new functionality or code changes.
Submission documents any new features or endpoints, and describes how developers
would be expected to interact with them.
Author has agreed to our contributor's agreement.