Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup cross-platform CI #77

Merged
merged 7 commits into from
Dec 28, 2024
Merged

Setup cross-platform CI #77

merged 7 commits into from
Dec 28, 2024

Conversation

BowTiedRadone
Copy link
Collaborator

@BowTiedRadone BowTiedRadone commented Dec 27, 2024

This PR configures a cross-platform CI setup to ensure compatibility across multiple operating systems (Ubuntu, macOS, and Windows). Resolves #75.

Jobs Configuration:

  • Tests Job: Runs all the project tests on Ubuntu and macOS using Node.js versions 18, 20, and 22.
  • Example Tests Job: Runs tests against the example Clarinet project on Ubuntu, macOS, and Windows using Node.js versions 18, 20, and 22.

@BowTiedRadone BowTiedRadone requested a review from a team as a code owner December 27, 2024 12:45
@moodmosaic
Copy link
Member

This resolves #75.

@BowTiedRadone BowTiedRadone force-pushed the feat/ci branch 2 times, most recently from 00fe59f to a0217ee Compare December 27, 2024 12:55
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@moodmosaic moodmosaic changed the title [DRAFT] Setup cross-platform CI Setup cross-platform CI Dec 27, 2024
@BowTiedRadone BowTiedRadone force-pushed the feat/ci branch 4 times, most recently from 39834d3 to dfee6e5 Compare December 27, 2024 17:23
README.md Show resolved Hide resolved
@BowTiedRadone BowTiedRadone force-pushed the feat/ci branch 2 times, most recently from f24fda0 to 1f9ba6d Compare December 27, 2024 17:31
@moodmosaic
Copy link
Member

Some checks still fail. Perhaps we want #73 here?

@BowTiedRadone
Copy link
Collaborator Author

Some checks still fail. Perhaps we want #73 here?

Until a fix for hirosystems/clarinet#1634, npm test will fail on Windows.

BowTiedRadone and others added 2 commits December 28, 2024 12:16
This commit removes `windows-latest` from the `os` matrix. Until a fix for
hirosystems/clarinet#1634, `npm test` will fail on Windows.
This commit separates the jobs for running regular tests and example tests.
Example tests are now included for Windows, increasing coverage until
hirosystems/clarinet#1634 is resolved.
Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Great work. Left a few nitpicks.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
This commit renames the CI and the examples job.

Co-authored-by: Nikos Baxevanis <[email protected]>
@moodmosaic moodmosaic merged commit a1467dd into master Dec 28, 2024
16 checks passed
@moodmosaic moodmosaic deleted the feat/ci branch December 28, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup CI/GitHub Actions
2 participants