feat: more efficient bitcoin transaction packages #1181
Conversation
creating a new one all the time
djordon
added
sbtc signer binary
| let above_limits = item_votes.count_ones() > self.max_votes_against | ||
| || self.total_vsize.saturating_add(item_vsize) > self.max_vsize; | ||
|
|
||
| if above_limits { |
There was a problem hiding this comment.
nit: can we add to the fn docstring that the item may not be inserted?
There was a problem hiding this comment.
mmm without having context the If no bag can fit the item then it is not added to any bag and is dropped may seem contradicting the preceding Creates a new one if no bag exists that can fit the item.
signer/src/bitcoin/utxo.rs
Outdated
| }; | ||
|
|
||
| let transactions = requests.construct_transactions().unwrap(); | ||
| assert_eq!(transactions.len(), 25); | ||
| assert_eq!(transactions.len(), 15); |
There was a problem hiding this comment.
IIUC this test was to check that we don't create a chain of more than MAX_TX_PER_BITCOIN_BLOCK txs, if so we should probably change the votes in deposits and withdrawals to force creating singleton transactions (eg, adding a | 0b111 and incrementing both shifts by 3).
There was a problem hiding this comment.
Hmmm, I thought that it was to check that the vsize was capped by MEMPOOL_MAX_PACKAGE_SIZE, but maybe it's both? Yeah, let's check both.
There was a problem hiding this comment.
Oh whoops, it's supposed to check that MAX_TX_PER_BITCOIN_BLOCK is capped.
There was a problem hiding this comment.
nit: the comment we should generate 60 distinct transactions is no longer true, given SbtcRequests allow for up to 4 votes against it should generate only ~30 transactions.
Description
Closes #1151 and closes #1047.
Changes
Testing Information
Added new unit tests for the new packager.
Checklist: