Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing proto definitions #878

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add missing proto definitions #878

wants to merge 5 commits into from

Conversation

matteojug
Copy link
Collaborator

@matteojug matteojug commented Nov 18, 2024 •
edited
Loading

Description

Closes: #846

Changes

Add missing proto definitions and update some with the latest changes.

Testing Information

Tested e2e on #880, and via conversions in #879.

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

djordon
djordon reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely looks good, had a few comments.

protobufs/crypto/common.proto Outdated Show resolved Hide resolved
protobufs/stacks/signer/v1/messages.proto Show resolved Hide resolved
protobufs/stacks/signer/v1/requests.proto Outdated Show resolved Hide resolved
djordon
djordon approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅ 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djordon djordon djordon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Add missing proto definitions for serialized messages
2 participants
@matteojug @djordon