Enable clippy in CI

[obycode]

Description

Applicable issues

• fixes [CI] Add clippy checks to the clarity subrepo #3979
• fixes [CI] Add clippy checks to pox-locking subrepo #4020
• fixes [CI] Add clippy checks to libstackerdb subrepo #4021
• fixes [CI] Add clippy checks to stacks-common subrepo #4022
• see Chore: Clippy Code Cleanup Story Ticket #3934

Additional info (benefits, drawbacks, caveats)

Checklist

• Test coverage for new or modified code paths
• Changelog is updated
• Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
• New clarity functions have corresponding PR in clarity-benchmarking repo
• New integration test(s) added to bitcoin-tests.yml

[obycode]

@wileyj after this is merged, can we add this "Clippy Check" as a required check?

[obycode]

Just realized that's probably not the right place to add the clippy job in ci.yml, since that one's only activated on pushes to master. I'm not clear on where it needs to go.

[codecov]

Codecov Report

Merging #4026 (6315b17) into develop (3b37332) will decrease coverage by 58.16%.
Report is 1 commits behind head on develop.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           develop    #4026       +/-   ##
============================================
- Coverage    58.31%    0.16%   -58.16%     
============================================
  Files            1      402      +401     
  Lines          571   287893   +287322     
============================================
+ Hits           333      469      +136     
- Misses         238   287424   +287186     

Files	Coverage Δ
clarity/src/vm/ast/mod.rs	0.00% <ø> (ø)
clarity/src/vm/ast/parser/v1.rs	0.00% <ø> (ø)
clarity/src/vm/analysis/errors.rs	0.00% <0.00%> (ø)
...ty/src/vm/analysis/type_checker/v2_05/tests/mod.rs	0.00% <0.00%> (ø)
...ity/src/vm/analysis/type_checker/v2_1/tests/mod.rs	0.00% <0.00%> (ø)
stacks-common/src/util/log.rs	0.00% <0.00%> (ø)
stacks-common/src/util/macros.rs	0.00% <0.00%> (ø)
stacks-common/src/util/pipe.rs	0.00% <0.00%> (ø)
clarity/src/vm/ast/parser/v2/mod.rs	0.00% <0.00%> (ø)
stacks-common/src/types/net.rs	0.00% <0.00%> (ø)
... and 1 more

... and 390 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[obycode]

I reverted the changes to ci.yml, but I don't understand yet why this job doesn't actually run.

[obycode]

Ah, I'm an idiot:

    if: ${{ false }}

I'll try removing that.

[wileyj]

Approving this so we have something in place for now, with the expectation that we'll want to reimplement what this remote workflow does since it is no longer maintained:
https://github.com/actions-rs/clippy-check

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.