Bind ports should not use the same port numbers

[jferrant]

No description provided.

[hstove]

What about something like this, which doesn't require tracking used ports within tests:

use std::collections::HashSet;
use std::sync::Mutex;
use rand::Rng;
use lazy_static::lazy_static;

lazy_static! {
    static ref USED_PORTS: Mutex<HashSet<u16>> = Mutex::new(HashSet::new());
}

pub fn gen_random_port() -> u16 {
    let mut rng = rand::thread_rng();

    loop {
        let port = rng.gen_range(1024..=65534);
        let mut ports = USED_PORTS.lock().unwrap();

        if !ports.contains(&port) {
            ports.insert(port);
            return port;
        }
    }
}

[jferrant]

EDIT: Thanks @hstove . Nice clean option. All good :D

[obycode]

Looks good, thanks! I just pointed out some cleanup to avoid warnings.

[obycode]

🎉 Now it's beautiful! 🤣 Thanks @jferrant!!

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.