Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy: static lifetime for consts #5646

Closed
wants to merge 1 commit into from
Closed

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Jan 3, 2025

This fixes some clippy warnings about not specifying explicit lifetimes for constants.

@obycode obycode requested a review from a team as a code owner January 3, 2025 20:30
@obycode obycode requested review from jbencin and jferrant January 3, 2025 20:30
@obycode obycode changed the title Clippy: static lifetime for costs Clippy: static lifetime for consts Jan 3, 2025
@jbencin
Copy link
Contributor

jbencin commented Jan 3, 2025

I'm confused. Didn't we just use Clippy to remove static from these variables in #5625 (which was merged yesterday)? Are you and @jferrant using different versions of Clippy which disagree?

@obycode
Copy link
Contributor Author

obycode commented Jan 3, 2025

I'm confused. Didn't we just use Clippy to remove static from these variables in #5625 (which was merged yesterday)? Are you and @jferrant using different versions of Clippy which disagree?

Oops! Yes, you're right 😅. I thought it was strange that it was asking me to add lifetimes when we had just deleted other lifetimes, but I forgot that it was the same lifetimes we just removed! 🤦‍♂️

@obycode
Copy link
Contributor Author

obycode commented Jan 3, 2025

I'm updating to the latest, 1.83, and checking which it wants...

@obycode
Copy link
Contributor Author

obycode commented Jan 3, 2025

Closing this. Sorry for the confusion.

@obycode obycode closed this Jan 3, 2025
@obycode obycode deleted the clippy/static-lifetime branch January 3, 2025 20:54
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants