Fix: explicit burnchain checks in miner thread #5717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obycode
reviewed
Jan 16, 2025
obycode
reviewed
Jan 16, 2025
obycode
reviewed
Jan 16, 2025
obycode
reviewed
Jan 16, 2025
jcnelson
approved these changes
Jan 16, 2025
|
LGTM, as long as CI passes modulo expected failures in 5515. |
obycode
approved these changes
Jan 16, 2025
obycode
reviewed
Jan 16, 2025
…ew-fix-burn-checks
…ew-fix-burn-checks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue in #5515 where a
BlockFound { late: true }mining thread would stay alive after a new burn block arrived (this caused flake in a previous test I wrote for that PR). This PR includes a test that consistently fails (I think I saw it pass once though?) in #5515, but passes with the changeset.This changeset adds a new instance variable to the mining thread which records what burn block initiated the mining thread (so this is the chain tip even in the case of a late block found). If the burn tip ever doesn't match that, it closes the miner.