chore: Apply Clippy format string lints #5723
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jferrant
previously approved these changes
Jan 17, 2025
jbencin
force-pushed
the
chore/clippy-format-strings
branch
from
c504bc0 to
856542d
Compare
obycode
reviewed
Jan 18, 2025
| format!("{}", &inner_key), | ||
| format!("{}", v), | ||
| format!("{}", &inner_val), | ||
| (&inner_key).to_string(), |
There was a problem hiding this comment.
I think we can drop the reference and parens on this and others:
Suggested change
| (&inner_key).to_string(), | |
| inner_key.to_string(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply Clippy lints related to format strings. Specifically, the following:
to_string_in_format_argsuseless_formatformat_in_format_argsAlso there's a few other random, non-Clippy fixes in here that I didn't want to make a separate PR for