feat: include PC abort reason in tx receipt #6018
Open
+293
−197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kantai
reviewed
Apr 16, 2025
kantai
reviewed
Apr 16, 2025
kantai
reviewed
Apr 16, 2025
hstove
suggested changes
Apr 17, 2025
github-project-automation
bot
moved this from Status: In Review
to Status: 💻 In Progress
in Stacks Core Eng
Previously, this callback returned a boolean indicating whether the transaction should be rolled back. Now it returns an optional string, where the string indicates a reason for the abort.
hstove
previously approved these changes
Apr 17, 2025
kantai
reviewed
Apr 18, 2025
kantai
reviewed
Apr 18, 2025
|
Merge conflict resolved and ready for re-review. |
hstove
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including this message (which currently only shows in the logs) should be very helpful for users to understand what went wrong in their transaction. I think another change is needed to pass this
vm_errorfrom the transaction receipt to event listeners, which would then enable the API to consume this information and show it in places like the Explorer. cc @zone117x