Create TransactionEventPayload struct and add vm_error to it

[jferrant]

Closes #6021

[codecov]

Codecov Report

Attention: Patch coverage is 87.09677% with 16 lines in your changes missing coverage. Please review.

Project coverage is 84.00%. Comparing base (cf9fc79) to head (707c09a).
Report is 32 commits behind head on develop.

Files with missing lines	Patch %	Lines
stackslib/src/net/api/mod.rs	42.85%	12 Missing ⚠️
testnet/stacks-node/src/event_dispatcher.rs	95.69%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6025      +/-   ##
===========================================
- Coverage    84.10%   84.00%   -0.10%     
===========================================
  Files          528      528              
  Lines       385765   386373     +608     
  Branches       323      323              
===========================================
+ Hits        324442   324577     +135     
- Misses       61315    61788     +473     
  Partials         8        8              

Files with missing lines	Coverage Δ
stackslib/src/chainstate/burn/operations/mod.rs	63.57% <100.00%> (+1.29%)	⬆️
testnet/stacks-node/src/event_dispatcher.rs	90.42% <95.69%> (+0.29%)	⬆️
stackslib/src/net/api/mod.rs	84.55% <42.85%> (-7.62%)	⬇️

... and 50 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7646f9...707c09a. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[obycode]

Looks good, just two small requests.

[obycode]

👍

[kantai]

This looks good to me, but we should have some tests that make tighter assertions about the outputted JSON -- we want this to be compatible with the previous version, so we should add some explicit equality checks on the outputted JSON with fixtures generated from the prior version.

[jferrant]

This looks good to me, but we should have some tests that make tighter assertions about the outputted JSON -- we want this to be compatible with the previous version, so we should add some explicit equality checks on the outputted JSON with fixtures generated from the prior version.

Added a proper deserializer for the custom block stack ops. Not sure that is exactly what you want. The equality check on the outputted JSON will not match. In my update, we now output the vm_error whereas before we did not. So the results will not match. They match on everything else and now that I have added the deserializer, it shows that it can serialize and deserialize into the same result whether using the legacy output or the current output. Note though that the serialization of some of those blockstack ops are lossy (For example PoxAddresses are serialized in a way that is lossy)