Fix: flaky net::tests::convergence tests

[obycode]

Description

If my read of these tests is correct, we are just looking for convergence, and these tests should not be testing the pruning of neighbors, so it is best to set these soft max values to be the same as the total number of peers to avoid any non-deterministic pruning. The pruning should be tested elsewhere. See later comments and fixes.

Applicable issues

• fixes Flaky test: net::tests::convergence::test_walk_ring_15_org_biased #5761
• fixes Flaky test: net::tests::convergence::test_walk_star_allowed_15 #5758
• fixes Flaky test: net::tests::convergence::test_walk_star_15_plain #5780

[obycode]

I made this change based on seeing peers being dropped in the logs with the reason, "the peer’s org dominates our peer table.”

[obycode]

Hmm... based on that CI failure, it seems that this is not the problem here.

[orsissimo]

In local and in my CI, those tests failed (with assertion left == right failed)
net::tests::convergence::test_walk_star_allowed_15 (Failed 16 times out of 140)
net::tests::convergence::test_walk_star_15_plain (Failed 19 times out of 140)

While net::tests::convergence::test_walk_ring_15_org_biased never did - but I further checked the CI runs and saw failures during some PR merges (4 failed out of 25 checked)

One thing I couldn't do was running the tests as a group and not one by one in CI (I could do it in local tho).

I catched those failures:

For net::tests::convergence::test_walk_star_15_plain

thread '<unnamed>' panicked at stackslib/src/net/tests/convergence.rs:1099:17:
assertion `left == right` failed
  left: [QualifiedContractIdentifier { issuer: StandardPrincipalData(S100000000000000000000J197CZ), name: ContractName("db-0") }, QualifiedContractIdentifier { issuer: StandardPrincipalData(S1G2081040G2081040G2081040G208105NK8PE5), name: ContractName("db-1") }]
 right: []

Failures are often preceded by:

INFO [stackslib/src/net/stackerdb/mod.rs:509] [ThreadId(3)] No stacker DB config for S12081040G2081040G2081040G2081040HYKVZCC.db-4
INFO [stackslib/src/net/p2p.rs:2013] [ThreadId(3)] Neighbor accepted!, public key: None, address: 127.0.0.1

While for net::tests::convergence::test_walk_star_allowed_15

thread '<unnamed>' panicked at stackslib/src/net/tests/convergence.rs:1099:17:
assertion `left == right` failed
  left: [QualifiedContractIdentifier { issuer: StandardPrincipalData(S100000000000000000000J197CZ), name: ContractName("db-0") }, QualifiedContractIdentifier { issuer: StandardPrincipalData(S1G2081040G2081040G2081040G208105NK8PE5), name: ContractName("db-1") }, ...]
 right: []

Failures are often preceded by:

INFO [stackslib/src/net/stackerdb/mod.rs:509] [ThreadId(3)] No stacker DB config for S130C1G60R30C1G60R30C1G60R30C1G60V982B5Y.db-6
INFO [stackslib/src/net/stackerdb/mod.rs:509] [ThreadId(3)] No stacker DB config for S1G2081040G2081040G2081040G208105NK8PE5.db-1

[obycode]

Updated with what I think is the correct fix (2 fixes actually).

• Peer 0 was not getting any stacker DBs, but it was expected to because 0 % 2 == 0
• The wait for convergence did not also wait for stacker DB convergence

[jferrant]

Noice. LGTM

[kantai]

Nice!

[codecov]

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.45%. Comparing base (b1545ee) to head (8ab3024).
Report is 46 commits behind head on develop.

Files with missing lines	Patch %	Lines
stackslib/src/net/tests/convergence.rs	90.90%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6046      +/-   ##
===========================================
+ Coverage    77.95%   83.45%   +5.50%     
===========================================
  Files          538      538              
  Lines       387064   387015      -49     
  Branches       323      323              
===========================================
+ Hits        301730   322985   +21255     
+ Misses       85326    64022   -21304     
  Partials         8        8              

Files with missing lines	Coverage Δ
stackslib/src/net/tests/convergence.rs	93.77% <90.90%> (-0.13%)	⬇️

... and 219 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d16bd3a...8ab3024. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.