Skip to content

Conversation

jferrant
Copy link
Contributor

@jferrant jferrant commented Jul 24, 2025

Fully closes #6314

This is nice to see:
Screenshot 2025-09-04 at 9 21 46 AM

@jferrant jferrant requested review from a team as code owners July 24, 2025 16:47
@jferrant jferrant moved this to Status: In Review in Stacks Core Eng Jul 24, 2025
@jferrant jferrant added this to the 3.2.0.0.1 milestone Jul 24, 2025
@jferrant jferrant self-assigned this Jul 24, 2025
@wileyj wileyj moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Jul 25, 2025
…rmation_maps from burnchain db

Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
@jcnelson
Copy link
Member

jcnelson commented Sep 4, 2025

This all looks great to me! Just waiting for this to be a non-draft and for CI to pass.

@jferrant
Copy link
Contributor Author

jferrant commented Sep 4, 2025

This all looks great to me! Just waiting for this to be a non-draft and for CI to pass.

I removed 5 tests in tests::epoch_21 and 1 from tests::epoch_22

… into chore/remove-affirmation-map-from-chainscoordinator
@jferrant jferrant requested review from jcnelson and kantai September 4, 2025 18:04
@jferrant jferrant marked this pull request as ready for review September 4, 2025 18:04
@jferrant jferrant requested a review from a team as a code owner September 4, 2025 18:04
kantai
kantai previously approved these changes Sep 5, 2025
Copy link
Contributor

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

obycode
obycode previously approved these changes Sep 5, 2025
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Very happy to see the affirmation maps gone! I just had one suggestion.

Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant jferrant dismissed stale reviews from obycode and kantai via f210934 September 5, 2025 18:11
@jferrant jferrant enabled auto-merge September 5, 2025 18:14
@jferrant jferrant disabled auto-merge September 5, 2025 18:14
@jferrant jferrant added this pull request to the merge queue Sep 5, 2025
Merged via the queue into stacks-network:develop with commit 591e6ee Sep 5, 2025
288 of 289 checks passed
@jferrant jferrant deleted the chore/remove-affirmation-map-from-chainscoordinator branch September 5, 2025 19:47
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Sep 5, 2025
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 83.72093% with 91 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.97%. Comparing base (d196052) to head (f210934).
⚠️ Report is 69 commits behind head on develop.

Files with missing lines Patch % Lines
stackslib/src/burnchains/db.rs 73.00% 27 Missing ⚠️
stackslib/src/chainstate/burn/db/sortdb.rs 82.25% 22 Missing ⚠️
stackslib/src/burnchains/tests/db.rs 87.50% 12 Missing ⚠️
stackslib/src/chainstate/coordinator/mod.rs 60.71% 11 Missing ⚠️
stackslib/src/chainstate/stacks/db/mod.rs 91.45% 10 Missing ⚠️
stackslib/src/net/inv/epoch2x.rs 77.27% 5 Missing ⚠️
stackslib/src/main.rs 0.00% 2 Missing ⚠️
stackslib/src/net/tests/inv/nakamoto.rs 77.77% 2 Missing ⚠️

❌ Your project status has failed because the head coverage (76.97%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6332      +/-   ##
===========================================
- Coverage    79.13%   76.97%   -2.17%     
===========================================
  Files          556      555       -1     
  Lines       351321   344533    -6788     
===========================================
- Hits        278017   265190   -12827     
- Misses       73304    79343    +6039     
Files with missing lines Coverage Δ
stacks-node/src/main.rs 0.00% <ø> (ø)
stacks-node/src/neon_node.rs 71.05% <ø> (-3.00%) ⬇️
stacks-node/src/node.rs 86.57% <100.00%> (+0.02%) ⬆️
stacks-node/src/run_loop/nakamoto.rs 86.90% <ø> (+0.30%) ⬆️
stacks-node/src/run_loop/neon.rs 80.06% <100.00%> (-3.92%) ⬇️
stacks-node/src/tests/epoch_21.rs 0.00% <ø> (ø)
stacks-node/src/tests/epoch_22.rs 0.00% <ø> (ø)
stacks-node/src/tests/neon_integrations.rs 17.85% <ø> (-17.97%) ⬇️
stacks-signer/src/client/mod.rs 99.24% <ø> (-0.01%) ⬇️
stackslib/src/burnchains/burnchain.rs 67.99% <ø> (-1.07%) ⬇️
... and 26 more

... and 96 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d196052...f210934. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants