-
Notifications
You must be signed in to change notification settings - Fork 700
Chore/remove affirmation map from chainscoordinator #6332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/remove affirmation map from chainscoordinator #6332
Conversation
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
…irmation_maps_at_height, and find_valid_sortitions Signed-off-by: Jacinta Ferrant <[email protected]>
…ain_block Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
…k_compatible_with_affirmation_map Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
… into chore/remove-affirmation-map-from-chainscoordinator
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
…dless of epoch Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
…rmation_maps from burnchain db Signed-off-by: Jacinta Ferrant <[email protected]>
…and update changelog Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
This all looks great to me! Just waiting for this to be a non-draft and for CI to pass. |
…evant Signed-off-by: Jacinta Ferrant <[email protected]>
I removed 5 tests in tests::epoch_21 and 1 from tests::epoch_22 |
… into chore/remove-affirmation-map-from-chainscoordinator
…olumn and add tests Signed-off-by: Jacinta Ferrant <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Very happy to see the affirmation maps gone! I just had one suggestion.
Signed-off-by: Jacinta Ferrant <[email protected]>
591e6ee
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (76.97%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6332 +/- ##
===========================================
- Coverage 79.13% 76.97% -2.17%
===========================================
Files 556 555 -1
Lines 351321 344533 -6788
===========================================
- Hits 278017 265190 -12827
- Misses 73304 79343 +6039
... and 96 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Fully closes #6314
This is nice to see:
