Skip to content

Conversation

lunargon
Copy link

@lunargon lunargon commented Aug 26, 2025

Update display VM error

Description

Right now vm will print "Stack Trace: " but then not have any stack trace -> update this not showing if empty stack trace

Applicable issues

Noted:

#[cfg(not(feature = "developer-mode"))]
pub fn make_stack_trace(&self) -> StackTrace {
Vec::new()
}

In this line if source not in developer-mode -> stack will be create new. So make sure source enable developer-mode.

@lunargon lunargon requested review from a team as code owners August 26, 2025 04:10
@CLAassistant
Copy link

CLAassistant commented Aug 26, 2025

CLA assistant check
All committers have signed the CLA.

obycode
obycode previously approved these changes Aug 26, 2025
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lunargon!

@obycode obycode moved this to Status: In Review in Stacks Core Eng Aug 26, 2025
@obycode obycode added this to the 3.2.0.0.2 milestone Aug 26, 2025
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.17%. Comparing base (4a7dfc2) to head (216bafe).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
clarity/src/vm/errors.rs 25.00% 3 Missing ⚠️

❌ Your project check has failed because the head coverage (71.17%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (4a7dfc2) and HEAD (216bafe). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (4a7dfc2) HEAD (216bafe)
128 117
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6421      +/-   ##
==========================================
- Coverage   78.10%   71.17%   -6.93%     
==========================================
  Files         558      552       -6     
  Lines      365409   351799   -13610     
==========================================
- Hits       285394   250394   -35000     
- Misses      80015   101405   +21390     
Files with missing lines Coverage Δ
clarity/src/vm/errors.rs 71.79% <25.00%> (-1.89%) ⬇️

... and 338 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaed1cc...216bafe. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@obycode obycode changed the base branch from master to develop August 28, 2025 11:07
@obycode obycode dismissed their stale review August 28, 2025 11:07

The base branch was changed.

@obycode
Copy link
Contributor

obycode commented Aug 28, 2025

@lunargon - I just realized this was targeting master, but PRs should target develop unless they are hot fixes. I've changed the target, please rebase and feel free to force push after that adjustment. Thanks!

@lunargon
Copy link
Author

@obycode thank you about that.

@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to the versioning scheme outlined in the [README.md](README.md).


## [Unreleased]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be a merge artifact?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That's merge artifact? I have updated that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still seems to be here. We should only see changes from commit 216bafe.

@hstove hstove self-requested a review September 4, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: In Review
Development

Successfully merging this pull request may close these issues.

Fix vm_error stack trace
5 participants