-
Notifications
You must be signed in to change notification settings - Fork 700
fix: not show empty Stack Trace
#6421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lunargon!
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (71.17%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## master #6421 +/- ##
==========================================
- Coverage 78.10% 71.17% -6.93%
==========================================
Files 558 552 -6
Lines 365409 351799 -13610
==========================================
- Hits 285394 250394 -35000
- Misses 80015 101405 +21390
... and 338 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…gner-3.2.0.0.1.1 Merge release/signer-3.2.0.0.1.1 to master
@lunargon - I just realized this was targeting |
@obycode thank you about that. |
@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file. | |||
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
and this project adheres to the versioning scheme outlined in the [README.md](README.md). | |||
|
|||
|
|||
## [Unreleased] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be a merge artifact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. That's merge artifact? I have updated that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still seems to be here. We should only see changes from commit 216bafe.
Update display VM error
Description
Right now vm will print "Stack Trace: " but then not have any stack trace -> update this not showing if empty
stack trace
Applicable issues
Noted:
stacks-core/clarity/src/vm/contexts.rs
Lines 1990 to 1993 in 7d8b675
In this line if source not in
developer-mode
-> stack will be create new. So make sure source enabledeveloper-mode
.