Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace resolveZoneFileToProfile from blockstack SDK #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pradel
Copy link
Contributor

@pradel pradel commented Feb 1, 2022

Description

While browsing the repo I found this function that can be extracted from the blockstack package. I will submit other pull requests if I find other parts that can be migrated easily.

Type of Change

Code change.

Does this introduce a breaking change?

No

Checklist

  • Code is commented where needed
  • Unit test coverage for new or modified code paths
  • npm run test passes
  • Changelog is updated
  • Tag 1 of @wileyj or @CharlieC3

@pradel pradel changed the title chore: replace part of blockstack SDK chore: replace resolveZoneFileToProfile from blockstack SDK Feb 1, 2022
@CharlieC3
Copy link
Member

Closing then re-opening PR to try and re-trigger CI.

@CharlieC3 CharlieC3 closed this Feb 1, 2022
@CharlieC3 CharlieC3 reopened this Feb 1, 2022
@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.19%. Comparing base (d2897c3) to head (1ea8e1b).
Report is 49 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   58.19%   58.19%           
=======================================
  Files           8        8           
  Lines         665      665           
=======================================
  Hits          387      387           
  Misses        278      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pradel
Copy link
Contributor Author

pradel commented Feb 1, 2022

I see that CI / build-publish (pull_request) is failing but it doesn't seems related to that pr

@CharlieC3
Copy link
Member

@pradel I'll submit a fix for that in a separate PR.

@CharlieC3 CharlieC3 requested a review from wileyj February 1, 2022 18:35
@CharlieC3
Copy link
Member

Closing then re-opening PR to try and re-trigger CI.

@CharlieC3 CharlieC3 closed this Feb 2, 2022
@CharlieC3 CharlieC3 reopened this Feb 2, 2022
@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants