feat: migrate flow to typescript #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be merged after : #80 to avoid merge conflicts!
Description
Migrated lookups.ts file from Flow to TypeScript as part of a bigger task to migrate the whole project types from Flow to TS.
Describe the changes that where made in this pull request. When possible start with a user story - short, simple descriptions of a feature told from the perspective of the person who desires the new capability. Be sure to also include the following information:
Following this PR the next task was to start migrating from Flow to Ts:
feat: update eslint config #80
This change is part of M1 of this grant:
Subdomain registrar improvement stacksgov/grants-program#282
After the whole repo is migrated to the TS it should
improve dev experience and productivity as TypeScript is used
across all the other Stacks repos.
Type of Change
Does this introduce a breaking change?
This does not include a breaking change.
Are documentation updates required?
Yes, once this will get a green light, I will add documentation for TS setup either on this branch or the one right after this one.
Testing information
lookups.tsnpm run tscand see no errors