Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to select geometry source #50

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add option to select geometry source #50

wants to merge 3 commits into from

Conversation

pjhartzell
Copy link
Contributor

@pjhartzell pjhartzell commented Oct 20, 2022 •
edited
Loading

Related Issue(s):
#48

Description:

  • Added abiliity to create Item geometry from a raster data footprint.
  • The method for creating Item geometry is now a required argument in the create_item function. There are 4 options.

Tests and mypy will be cleaned up once we firm up the approach.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Examples have been updated to reflect changes, if applicable
  • Changes are added to the CHANGELOG.

gadomski
gadomski reviewed Oct 20, 2022
View reviewed changes
src/stactools/landsat/constants.py Outdated Show resolved Hide resolved
src/stactools/landsat/utils.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski left review comments

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjhartzell @gadomski