Autocomplete search for Android Demo App #295

ianthetechie · 2024-10-13T01:50:38Z

This makes the Android demo app into something more like a "normal" navigation experience with a single map view for everything and an autocomplete overlay. This involved... a few things ;)

Making the map view usable without an active navigation session.
Using the grid views for completely custom user overlays.
Tip-toeing around a lot of very bad ™️ things in MapLibre Android wrt camera and user location tracking on init.
Making the demo scene work with either simulated or live location providers

Usage as a non-nav map

In the process, I had to address most of the same issues on Android that @hactar ran into with using this as a non-navigation map in #275. I tried a few ideas and ended up with a fairly similar approach (after accounting for Kotlin + Jetpack idioms) as that PR. Since I wasn't intending to do that by any means, I'm now pretty sure that the iOS PR is also going the right direction, so I'll figure out what else we need to do to get that over the line.

NOTE: I have not yet deeply thought through the Jetpack approach to super deep customization like we do with chainable modifiers in SwiftUI, but I think this PR gets Android most of the way there, and it started from a significantly worse state than iOS.

Outstanding tasks

Thoroughly test the "new install" flow (with permissions prompts)
Decide on how to simulate navigation (button in the UI?), have the demo scene switch to the simulated provider during the simulated trip, and then switch back as soon as it's done.
The camera should switch to the navigating camera automatically when starting a trip; it's supposed to but I think I broke something

Misc

While doing this, I realized that we can probably move the grid stuff to the compose playground (same thing for SwiftUI). This seems to be generally useful and I think we can move this outside Ferrostar and build on top of it with our "defaults" since it's all composable :)

…ptions)

…ation

Archdoog

Looking pretty sweet 👍. A handful of deeper comments we probably need to discuss and get sorted pretty soon. Though we can merge this before we solve them, as this PR definitely improves things from main.

android/README.md

android/composeui/src/main/res/drawable/direction_u_turn.xml

android/core/src/main/java/com/stadiamaps/ferrostar/core/Location.kt

Archdoog · 2024-10-13T17:44:10Z

android/core/src/main/java/com/stadiamaps/ferrostar/core/NavigationViewModel.kt

+  fun isNavigating(): Boolean = uiState.value.progress != null
+}
+
+class IdleNavigationViewModel(locationProvider: LocationProvider) :


This behavior probably needs to go directly into the DefaultNavigationViewModel. Since our android implementation is still a little incorrect. In practice most architectures should only inject a single view model from their AppModule into their navigation scene/view.

Archdoog · 2024-10-13T17:47:12Z

android/demo-app/src/main/java/com/stadiamaps/ferrostar/AppModule.kt

@@ -65,11 +69,12 @@ object AppModule {
    FerrostarForegroundServiceManager(appContext, DefaultForegroundNotificationBuilder(appContext))
  }

+  // TODO: This is hard-coded for golf cart routing; change to something else before merging


Probably also "make this configurable" 😄.

ha! Yeah, I'm open to that if we can do it without too much work. There's a fine line between a demo app and recreating Google Maps ;)

We can throw in a segmented button here with walking, cycling, and driving and call it a day: https://developer.android.com/reference/kotlin/androidx/compose/material3/package-summary#SingleChoiceSegmentedButtonRow(androidx.compose.ui.Modifier,androidx.compose.ui.unit.Dp,kotlin.Function1)

android/demo-app/src/main/java/com/stadiamaps/ferrostar/DemoNavigationScene.kt

Archdoog · 2024-10-13T18:41:10Z

android/demo-app/src/main/java/com/stadiamaps/ferrostar/DemoNavigationScene.kt

+                        scope.launch(Dispatchers.IO) {
+                          // TODO: Fail gracefully
+                          val routes =
+                              AppModule.ferrostarCore.getRoutes(
+                                  loc,
+                                  listOf(
+                                      Waypoint(
+                                          coordinate =
+                                              GeographicCoordinate(
+                                                  center.latitude, center.longitude),
+                                          kind = WaypointKind.BREAK),
+                                  ))
+
+                          val route = routes.first()
+                          viewModel = AppModule.ferrostarCore.startNavigation(route = route)
+
+                          if (locationProvider is SimulatedLocationProvider) {
+                            locationProvider.setSimulatedRoute(route)
+                          }


With regards to view models, this looks like a prime example of functionality that should exist in one.

I wonder if we use this as an excuse (or put a TODO) to try and extend our default NavigationViewModel behaviors. It might push us to figure out a pattern that makes the DefaultNavigationViewModel extendable and overridable.

Happy to put this in a new ticket, but this composable is getting a lot of view model-like behavior in it and highlights something many developers will probably want. That being a default NavigationViewModel with app specific customizations alongside it. Currently, my app is using a second app specific view model alongside the DefaultNavigationViewModel to work around this issue, not ideal but works.

android/maplibreui/src/main/java/com/stadiamaps/ferrostar/maplibreui/NavigationMapView.kt

android/demo-app/src/main/java/com/stadiamaps/ferrostar/DemoNavigationScene.kt

ianthetechie · 2024-10-14T00:39:14Z

android/demo-app/src/main/java/com/stadiamaps/ferrostar/MainActivity.kt

+    //    AppModule.locationProvider.lastLocation = initialSimulatedLocation
+    //    AppModule.locationProvider.warpFactor = 2u


The TODO here is to enable switching location providers.

Let's do another segmented control ;)

...rc/main/java/com/stadiamaps/ferrostar/maplibreui/views/DynamicallyOrientingNavigationView.kt

Co-authored-by: Jacob Fielding <[email protected]>

ianthetechie · 2024-10-22T01:35:09Z

Discussed on today's call. We will merge with some minor cleanup and changing the default profile to something more common than golf carts for now and keep improving things. Stuff we still want to fix in the short term:

The demo app should have its own view model eventually
Switching location providers (to allow simulated routes without code changes)

We agreed it's best to merge early though since this definitely improves things a lot + lets devs test :)

* Support arbitrary Valhalla options (formerly we only merged costing options) * Fix argument * Improve docs of some convenience initializers * Align Android with iOS costing options * swiftformat * Don't forget the web ;) * Add Android-specific README * Set up Android to use API keys properly via local.properties * Fix CI * Fix subtle bug where Android location providers never updated lastLocation * Rename U-Turn images to match how Kotlin stringifies the maneuvers * Allow the fused location provider to report an initial fix faster * First pass at an actually usable demo app * Minor build script improvement * Checkpoint commit phase 1 * Checkpoint commit phase 2 highlighting some bad stuff to clean up * Add docs on the StaticLocationEngine * Fix formatting + doc test * Fix typo in Android readme Co-authored-by: Jacob Fielding <[email protected]> * Kotlin let closure idiom * ktfmtFormat + auto-commit * Remove extraneous env? * Try switching to a mix of Apple Silicon Ubuntu runners for Android * Fix runner permissions (I think) * Apply automatic changes * Address open thread re: iOS uturn image name * Add TODO docs * Fix the navigation camera (re-)application logic * Cleanup * Remove old comment * Apply automatic changes --------- Co-authored-by: Jacob Fielding <[email protected]> Co-authored-by: ianthetechie <[email protected]>

* Support for visual sub-maneuvers * Address PR comments * Added and updated tests * Update release version * Fix a typo * Update _typos.toml to ignore extended response * Update common/ferrostar/src/routing_adapters/osrm/models.rs Co-authored-by: Ian Wagner <[email protected]> * Add Prettier (#304) * Update ferrostar version * Add prettier * Run Prettier * Update guide * Rename format to format:fix, add format:check script * Add format:check to GitHub workflow * Autocomplete search for Android Demo App (#295) * Support arbitrary Valhalla options (formerly we only merged costing options) * Fix argument * Improve docs of some convenience initializers * Align Android with iOS costing options * swiftformat * Don't forget the web ;) * Add Android-specific README * Set up Android to use API keys properly via local.properties * Fix CI * Fix subtle bug where Android location providers never updated lastLocation * Rename U-Turn images to match how Kotlin stringifies the maneuvers * Allow the fused location provider to report an initial fix faster * First pass at an actually usable demo app * Minor build script improvement * Checkpoint commit phase 1 * Checkpoint commit phase 2 highlighting some bad stuff to clean up * Add docs on the StaticLocationEngine * Fix formatting + doc test * Fix typo in Android readme Co-authored-by: Jacob Fielding <[email protected]> * Kotlin let closure idiom * ktfmtFormat + auto-commit * Remove extraneous env? * Try switching to a mix of Apple Silicon Ubuntu runners for Android * Fix runner permissions (I think) * Apply automatic changes * Address open thread re: iOS uturn image name * Add TODO docs * Fix the navigation camera (re-)application logic * Cleanup * Remove old comment * Apply automatic changes --------- Co-authored-by: Jacob Fielding <[email protected]> Co-authored-by: ianthetechie <[email protected]> * Fix ManeuverImage * Fix ManeuverImage again * Fix newline ending --------- Co-authored-by: Ian Wagner <[email protected]> Co-authored-by: Mike Hays <[email protected]> Co-authored-by: Ian Wagner <[email protected]> Co-authored-by: Jacob Fielding <[email protected]> Co-authored-by: ianthetechie <[email protected]>

ianthetechie added 22 commits September 25, 2024 19:20

Support arbitrary Valhalla options (formerly we only merged costing o…

8f584e5

…ptions)

Fix argument

4d7fda9

Improve docs of some convenience initializers

616b5e4

Align Android with iOS costing options

02dd283

swiftformat

306a121

Don't forget the web ;)

02bb61b

Add Android-specific README

eb5a9e7

Set up Android to use API keys properly via local.properties

5100feb

Fix CI

b97d5fa

Fix subtle bug where Android location providers never updated lastLoc…

8ff64b4

…ation

Rename U-Turn images to match how Kotlin stringifies the maneuvers

10f0c72

Allow the fused location provider to report an initial fix faster

db4c02e

First pass at an actually usable demo app

afce8ff

Merge branch 'main' into autocomplete-search

7a84dff

Merge branch 'main' into autocomplete-search

5fe9eff

Merge branch 'main' into autocomplete-search

924ea21

Minor build script improvement

8f5bec4

Merge branch 'main' into autocomplete-search

5f7abfb

Checkpoint commit phase 1

37a4511

Checkpoint commit phase 2 highlighting some bad stuff to clean up

f81cb8a

Merge branch 'main' into autocomplete-search

40d6470

Add docs on the StaticLocationEngine

9e887d6

ianthetechie requested a review from Archdoog October 13, 2024 01:51

Fix formatting + doc test

784832a

Archdoog reviewed Oct 13, 2024

View reviewed changes

ianthetechie commented Oct 14, 2024

View reviewed changes

android/demo-app/src/main/java/com/stadiamaps/ferrostar/DemoNavigationScene.kt Outdated Show resolved Hide resolved

ianthetechie commented Oct 14, 2024

View reviewed changes

...rc/main/java/com/stadiamaps/ferrostar/maplibreui/views/DynamicallyOrientingNavigationView.kt Outdated Show resolved Hide resolved

ianthetechie and others added 2 commits October 14, 2024 09:41

Fix typo in Android readme

454309e

Co-authored-by: Jacob Fielding <[email protected]>

Kotlin let closure idiom

821fd8a

ianthetechie and others added 9 commits October 14, 2024 10:15

ktfmtFormat + auto-commit

ea883b1

Remove extraneous env?

b8fc590

Try switching to a mix of Apple Silicon Ubuntu runners for Android

d5f5274

Fix runner permissions (I think)

7501991

Apply automatic changes

ff295fc

Merge branch 'main' into autocomplete-search

57e21d2

Address open thread re: iOS uturn image name

84745b0

Add TODO docs

71622fd

Fix the navigation camera (re-)application logic

7510aa8

ianthetechie and others added 3 commits October 22, 2024 15:39

Cleanup

56cb38f

Remove old comment

b9211cb

Apply automatic changes

f80c494

ianthetechie merged commit 40ee690 into main Oct 22, 2024

ianthetechie deleted the autocomplete-search branch October 22, 2024 07:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autocomplete search for Android Demo App #295

Autocomplete search for Android Demo App #295

ianthetechie commented Oct 13, 2024 •

edited

Loading

Archdoog left a comment

Archdoog Oct 13, 2024

Archdoog Oct 13, 2024

ianthetechie Oct 14, 2024

ianthetechie Oct 15, 2024

Archdoog Oct 13, 2024

ianthetechie Oct 14, 2024

ianthetechie Oct 15, 2024

ianthetechie commented Oct 22, 2024

		// AppModule.locationProvider.lastLocation = initialSimulatedLocation
		// AppModule.locationProvider.warpFactor = 2u

Autocomplete search for Android Demo App #295

Autocomplete search for Android Demo App #295

Conversation

ianthetechie commented Oct 13, 2024 • edited Loading

Usage as a non-nav map

Outstanding tasks

Misc

Archdoog left a comment

Choose a reason for hiding this comment

Archdoog Oct 13, 2024

Choose a reason for hiding this comment

Archdoog Oct 13, 2024

Choose a reason for hiding this comment

ianthetechie Oct 14, 2024

Choose a reason for hiding this comment

ianthetechie Oct 15, 2024

Choose a reason for hiding this comment

Archdoog Oct 13, 2024

Choose a reason for hiding this comment

ianthetechie Oct 14, 2024

Choose a reason for hiding this comment

ianthetechie Oct 15, 2024

Choose a reason for hiding this comment

ianthetechie commented Oct 22, 2024

ianthetechie commented Oct 13, 2024 •

edited

Loading