[STA-3429] pre-release: do not apply pre-release tag to 0.x.x versions #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meorphis
changed the title
meorphis
changed the title
meorphis
changed the title
dgellow
reviewed
Jan 29, 2024
| @@ -6908,7 +6908,7 @@ version = "3.0.0" | |||
| ); | |||
| }); | |||
|
|
|||
| it('should build prerelease releases from pre-major', async () => { | |||
| it('should not build prerelease releases from pre-major', async () => { | |||
There was a problem hiding this comment.
Do we have a test case that covers 0.x.y AND the label autorelease: pre-release? To be sure users have a way to overwrite that behavior if they want a specific release to be tagged as pre-release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes it so that we do not apply the prerelease GH tag to
0.x.xversionsTest Plan
Update existing test for this case