Improve installer creation #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stal12 The PR is ready for review if you want to take a look. The first comment contains a brief description of what i've done in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I've managed to upgrade the installer to use WiX Toolset v4 and to ease up the installer build process since the old one was a little tricky and the toolset was deprecated.
The installer have been rewritten from scratch using the new WiX v4 schema and with little improvements.
Some scripts have been added to improve the installer build process. In fact:
installer/Windows/scripts/CreateWIXComponents.ps1PowerShell script will automatically generate WiX components to be put inside the installer;installer/Windows/x64CreateInstaller.ps1PowerShell script will automatically create the installer inside theinstaller/Windows/buildfolder;New documentation on the installer creation process have been added so it's a bit easier to remember.