Make gethostname an optional feature #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there @mdecimus!
I am a happy user of several of your email crates, including mail-builder. I want to be able to use mail-builder without depending on
gethostname
. I propose making the dependency ongethostname
optional, but enabled by default, so that existing users of this crate are not disrupted in any way.This change has three benefits:
MessageBuilder
never blocks, so it's usable inside an async context.While the usage of
#[cfg(...)]
inline is a bit awkward, I found it was the simplest way to achieve my goal. The alternatives were:&str
returned bygethostname
.