Add initial MLT support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
springmeyer
reviewed
Jun 20, 2024
springmeyer
reviewed
Jun 28, 2024
springmeyer
reviewed
Jun 28, 2024
springmeyer
reviewed
Jun 28, 2024
springmeyer
reviewed
Jun 28, 2024
| const tilesetMetadata = TileSetMetadata.fromBinary(metadata); | ||
|
|
||
| const vectorTile = new vt.VectorTile( | ||
| new Uint8Array(response.data), |
There was a problem hiding this comment.
This new Uint8Array allocation may be expensive. We should investigate why this seems needed and how to avoid this so we can pass the response.data directly. Perhaps create a ticket on this and I can take a closer look?
There was a problem hiding this comment.
I'm down to open an issue for this, the root of it is that the decoder needs a Uint8Array but we're getting an ArrayBuffer here. It seems like Uint8Array is the common type between node and the browser here?
There was a problem hiding this comment.
A similar conversion may be happening in pbf here.
springmeyer
reviewed
Jun 28, 2024
Co-authored-by: Dane Springmeyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial MLT support.