Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random fixes #564

Merged
merged 4 commits into from
Dec 26, 2024
Merged

Random fixes #564

merged 4 commits into from
Dec 26, 2024

Conversation

babalicious-io
Copy link
Collaborator

@babalicious-io babalicious-io commented Dec 20, 2024

UI/Styling Enhancements

This PR includes comprehensive UI and styling improvements across multiple components, focusing on consistency and mobile responsiveness.

Key Changes

Component Styling

  • Implemented new ScrollContainer component for consistent scrolling behavior
  • Added dark-gradient-modal variant for improved modal backgrounds
  • Standardized table styling patterns across components
  • Enhanced hover states with consistent purple highlight (hover:bg-stamp-purple/10)

Mobile Responsiveness

  • Consistent use of breakpoints (mobileLg, mobileMd, tablet)
  • Responsive text sizing (text-sm/text-base)
  • Improved table layouts for mobile views
  • Better handling of address abbreviations on different screen sizes

UI Improvements

  • Standardized row heights (h-8)
  • Enhanced tooltip visibility controls
  • Improved table column widths and spacing
  • Added cursor feedback for interactive elements
  • Removed redundant padding declarations

Code Quality

  • Consistent class naming conventions
  • Improved accessibility with aria-labels
  • Better event handling for navigation
  • Removed deprecated memo column from transfers

Testing Status

These changes have been reviewed for styling consistency and mobile responsiveness patterns. The PR will be rebased onto the main branch before merging.

Note: This PR is part of a larger UI enhancement effort focusing on consistent styling and improved user experience across the application.

@babalicious-io
Copy link
Collaborator Author

5cdb817

Look thru the code, I ended up having to improvise solutions. Since the font is not monospace there is code calculating the width of characters and some dynamic inputfield width stuff, mixed in with character limits - complimentary of Claude.
Most importantly check the MAX text button is done correctly - quite a fun puzzle.

Should be able to copy it to the Donate modal

@devin-ai-integration devin-ai-integration bot force-pushed the baba/random_fixes_part15 branch from c9f2c2e to 723ef1f Compare December 26, 2024 17:19
@reinamora137 reinamora137 force-pushed the baba/random_fixes_part15 branch 2 times, most recently from a348532 to a3fc061 Compare December 26, 2024 19:58
@reinamora137
Copy link
Contributor

Need to fix lint errors introduced with this PR

Error linting: /home/runner/work/BTCStampsExplorer/BTCStampsExplorer/components/stampDetails/StampDispensers.tsx
Expression expected at file:///home/runner/work/BTCStampsExplorer/BTCStampsExplorer/components/stampDetails/StampDispensers.tsx:33:1

const tableLabel =

error[no-window]: Window is no longer available in Deno
--> /home/runner/work/BTCStampsExplorer/BTCStampsExplorer/components/shared/HoldersGraph.tsx:34:5
 | 
34 |     window.location.href = `/wallet/${address}`;
 |     ^^^^^^
 = hint: Instead, use `globalThis`

docs: https://lint.deno.land/rules/no-window


error[no-window]: Window is no longer available in Deno
--> /home/runner/work/BTCStampsExplorer/BTCStampsExplorer/components/stampDetails/StampSales.tsx:37:5
 | 
37 |     window.location.href = `/wallet/${address}`;
 |     ^^^^^^
 = hint: Instead, use `globalThis`

docs: https://lint.deno.land/rules/no-window


error[no-window]: Window is no longer available in Deno
--> /home/runner/work/BTCStampsExplorer/BTCStampsExplorer/components/stampDetails/StampTransfers.tsx:34:5
 | 
34 |     window.location.href = `/wallet/${address}`;
 |     ^^^^^^
 = hint: Instead, use `globalThis`

docs: https://lint.deno.land/rules/no-window


error[no-unused-vars]: `tooltip` is never used
--> /home/runner/work/BTCStampsExplorer/BTCStampsExplorer/islands/stamp/details/StampInfo.tsx:90:9
 | 
90 |   const tooltip =
 |         ^^^^^^^
 = hint: If this is intentional, prefix it with an underscore like `_tooltip`

docs: https://lint.deno.land/rules/no-unused-vars


error[no-unused-vars]: `useCallback` is never used
--> /home/runner/work/BTCStampsExplorer/BTCStampsExplorer/islands/Wallet/details/WalletSendModal.tsx:1:10
| 
1 | import { useCallback, useEffect, useRef, useState } from "preact/hooks";
|          ^^^^^^^^^^^
= hint: If this is intentional, alias it with an underscore like `useCallback as _useCallback`

docs: https://lint.deno.land/rules/no-unused-vars


error[no-unused-vars]: `estimateFee` is never used
--> /home/runner/work/BTCStampsExplorer/BTCStampsExplorer/islands/Wallet/details/WalletSendModal.tsx:6:10
| 
6 | import { estimateFee } from "$lib/utils/minting/feeCalculations.ts";
|          ^^^^^^^^^^^
= hint: If this is intentional, alias it with an underscore like `estimateFee as _estimateFee`

docs: https://lint.deno.land/rules/no-unused-vars


error[no-unused-vars]: `Output` is never used
--> /home/runner/work/BTCStampsExplorer/BTCStampsExplorer/islands/Wallet/details/WalletSendModal.tsx:7:15
| 
7 | import type { Output } from "$types/index.d.ts";
|               ^^^^^^
= hint: If this is intentional, alias it with an underscore like `Output as _Output`

docs: https://lint.deno.land/rules/no-unused-vars


error[no-unused-vars]: `balance` is never used
--> /home/runner/work/BTCStampsExplorer/BTCStampsExplorer/islands/Wallet/details/WalletSendModal.tsx:17:48
 | 
17 |   { fee: initialFee, handleChangeFee, onClose, balance }: WalletSendModalProps,
 |                                                ^^^^^^^
 = hint: If this is intentional, prefix it with an underscore like `_balance`

docs: https://lint.deno.land/rules/no-unused-vars


error[no-unused-vars]: `isSendingMax` is never used
--> /home/runner/work/BTCStampsExplorer/BTCStampsExplorer/islands/Wallet/details/WalletSendModal.tsx:20:10
 | 
20 |   const [isSendingMax, setIsSendingMax] = useState(false);
 |          ^^^^^^^^^^^^
 = hint: If this is intentional, prefix it with an underscore like `_isSendingMax`

docs: https://lint.deno.land/rules/no-unused-vars


error[no-unused-vars]: `setIsSendingMax` is never used
--> /home/runner/work/BTCStampsExplorer/BTCStampsExplorer/islands/Wallet/details/WalletSendModal.tsx:20:24
 | 
20 |   const [isSendingMax, setIsSendingMax] = useState(false);
 |                        ^^^^^^^^^^^^^^^
 = hint: If this is intentional, prefix it with an underscore like `_setIsSendingMax`

docs: https://lint.deno.land/rules/no-unused-vars


Error: Process completed with exit code 1.

devin-ai-integration bot and others added 4 commits December 26, 2024 21:28
This PR includes comprehensive UI and styling improvements across multiple components, focusing on consistency and mobile responsiveness.

- Implemented new ScrollContainer component for consistent scrolling behavior
- Added dark-gradient-modal variant for improved modal backgrounds
- Standardized table styling patterns across components
- Enhanced hover states with consistent purple highlight (hover:bg-stamp-purple/10)

- Consistent use of breakpoints (mobileLg, mobileMd, tablet)
- Responsive text sizing (text-sm/text-base)
- Improved table layouts for mobile views
- Better handling of address abbreviations on different screen sizes

- Standardized row heights (h-8)
- Enhanced tooltip visibility controls
- Improved table column widths and spacing
- Added cursor feedback for interactive elements
- Removed redundant padding declarations

- Consistent class naming conventions
- Improved accessibility with aria-labels
- Better event handling for navigation
- Removed deprecated memo column from transfers

Co-Authored-By: [email protected] <[email protected]>
@reinamora137 reinamora137 force-pushed the baba/random_fixes_part15 branch from 269aee6 to 0be6ba7 Compare December 26, 2024 21:28
@reinamora137 reinamora137 merged commit 6d0fe83 into dev Dec 26, 2024
2 checks passed
@reinamora137 reinamora137 deleted the baba/random_fixes_part15 branch December 26, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants