-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tables refactor #651
Merged
Merged
Tables refactor #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2025
…amp detail page (instead of StampRelatedInfo)
…er-TxHash + link const
930c79c
to
e033f3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a global table template - Tables.tsx - and table syles - TableStyles.ts - that handles all stamps and token tables (on their details page)
Table content files have been refactored and much of the definitions/handling moved to Table and TableStyles
StampListingsAll.tsx / StampSales.tsx / StampTransfers.tsx / TokenMints.tsx / TokenTransfers.tsx
TableStyles.ts
Tables.tsx
Table content
HoldersGraph.tsx
StampListingsOpen.tsx - select listings part of the StampInfo buy button
I have attempted to refactor as best to my (and Claude's) knowledge - text linking could be refactored - everything should be reviewed and can probably be optimised some more
I haven't changed anything else with the HoldersGraph, since it's loading fast - the difference is that this table loads all rows instead of just 20 rows at a time (needs to be an island instead of a component to do this) - but it doesn't seem to slow it down
Tab counts for tables with many rows loads slow - same for infinite scroll - /src20/stamp
StampSales and StampTransfers DATE data is "unstable", sometimes it displays other times shows INVALID
StampListingsAll and StampListingsOpen are prepared for adding MARKETPLACE listings
I attempted to display a NO LISTINGS/SALES/TRANSFERS/MINTS text if the table data is empty, but got stuck in Claude's circular logic and couldn't get it to work