-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: filter panel for art stamps #661
base: dev
Are you sure you want to change the base?
Conversation
islands/datacontrol/FilterToggle.tsx
Outdated
<div | ||
class={`relative flex flex-col items-center gap-1 rounded-md h-fit border-stamp-purple-bright text-stamp-purple-bright`} | ||
> | ||
<Badge text="1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: count number of applied filters to populate this badge
} from "./StampFilterPane.tsx"; | ||
import { expect } from "jsr:@std/expect"; | ||
|
||
Deno.test("filterToQueryParams - does not encode false values", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: unit tests to make sure the encoding and decode to ui state and query params works
} | ||
|
||
export function queryParamsToServicePayload(query: string) { | ||
return filtersToServicePayload(queryParamsToFilters(query)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will eventually be where we map the query params to the body the service is expecting to filter better.
b49323c
to
6e7c1d2
Compare
fyi - the icon pack used |
Thanks. I was just letting the agent make me some |
…TCStampsExplorer into gjr/filter-panel
…d the sort into stamp header
some early renders of desktop and mobile views