Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: filter panel for art stamps #661

Draft
wants to merge 19 commits into
base: dev
Choose a base branch
from
Draft

wip: filter panel for art stamps #661

wants to merge 19 commits into from

Conversation

wichopy
Copy link
Collaborator

@wichopy wichopy commented Jan 19, 2025

some early renders of desktop and mobile views

Screenshot 2025-01-19 at 8 19 50 AM
Screenshot 2025-01-19 at 8 19 44 AM
Screenshot 2025-01-19 at 8 19 37 AM

<div
class={`relative flex flex-col items-center gap-1 rounded-md h-fit border-stamp-purple-bright text-stamp-purple-bright`}
>
<Badge text="1" />
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: count number of applied filters to populate this badge

} from "./StampFilterPane.tsx";
import { expect } from "jsr:@std/expect";

Deno.test("filterToQueryParams - does not encode false values", () => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: unit tests to make sure the encoding and decode to ui state and query params works

}

export function queryParamsToServicePayload(query: string) {
return filtersToServicePayload(queryParamsToFilters(query));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will eventually be where we map the query params to the body the service is expecting to filter better.

Base automatically changed from gjr/use-breakpoints to dev January 19, 2025 15:25
@babalicious-io
Copy link
Collaborator

Nice idea with displaying the amount of filters activated !

Think it would look better if it was positioned top/left instead - either purple or grey background
Could also display the number inside the button, instead of the filter icon - or with a darker filter icon (#440066) behind the number

Screenshot 2025-01-20 at 14 21 46

Screenshot 2025-01-20 at 14 35 48

@babalicious-io
Copy link
Collaborator

An alternative design option to checkboxes is having the text selectable
unselected - darker grey (#666666) / gradient
selected - light grey (#CCCCCC)

Screenshot 2025-01-20 at 15 00 11
Screenshot 2025-01-20 at 14 58 45

@babalicious-io
Copy link
Collaborator

@wichopy
Copy link
Collaborator Author

wichopy commented Jan 22, 2025

fyi - the icon pack used

https://www.figma.com/community/file/903830135544202908/phosphor-icons

Thanks. I was just letting the agent make me some

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants