Add update script for rstan submodule #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, but I've asked Nic to take a closer look |
|
Hey! Sorry I had a busy week. Thanks! |
serban-nicusor-toptal
approved these changes
Jan 21, 2025
No worries, thanks a bunch! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that rstan's
developbranch is up to date, we can start triggering the automatic update of the stan submoduleFrom what I can see in the stan Jenkinsfile I need to add this pull request script for rstan, which would be called by
utils.updateUpstream(env,'rstan'), but let me know if I'm in the wrong place!I also haven't tested this (since I'm not sure how), but I've just taken the existing
cmdstanscript and changed the file path - so please check if I've missed anything!