Skip to content

Use include_paths in subdirectories for pre-compiled models #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Jun 3, 2025

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Fixes #1094.

This does seem to fix #1094, but marking it as a draft PR for now. I need to add a test and to check a bit more whether this is the best way to fix this and whether this change affects anything that isn't covered by our current tests (we do have tests for includes, but they were missing this case so maybe are missing other cases that this affects).

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.12%. Comparing base (c57888e) to head (989ddaf).

Files with missing lines Patch % Lines
R/model.R 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1095      +/-   ##
==========================================
- Coverage   87.22%   87.12%   -0.11%     
==========================================
  Files          14       14              
  Lines        5973     5972       -1     
==========================================
- Hits         5210     5203       -7     
- Misses        763      769       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include_paths dropped for pre-compiled models in subdirectories
2 participants