Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures under cmdstan 2.34 #905

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Fix test failures under cmdstan 2.34 #905

merged 3 commits into from
Jan 22, 2024

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Fix test failures under cmdstan 2.34

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d444e7f) 88.37% compared to head (68e504d) 88.28%.
Report is 6 commits behind head on master.

❗ Current head 68e504d differs from pull request most recent head 03b5cbb. Consider uploading reports for the commit 03b5cbb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
- Coverage   88.37%   88.28%   -0.10%     
==========================================
  Files          12       12              
  Lines        4535     4534       -1     
==========================================
- Hits         4008     4003       -5     
- Misses        527      531       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrjohns andrjohns merged commit cd7b94b into master Jan 22, 2024
12 checks passed
@andrjohns andrjohns deleted the v2.34-compat branch January 22, 2024 00:10
@jgabry
Copy link
Member

jgabry commented Jan 22, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants